From owner-freebsd-geom@FreeBSD.ORG Fri Dec 17 14:19:29 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 786391065673 for ; Fri, 17 Dec 2010 14:19:29 +0000 (UTC) (envelope-from lev@serebryakov.spb.ru) Received: from ftp.translate.ru (ftp.translate.ru [80.249.188.42]) by mx1.freebsd.org (Postfix) with ESMTP id 36ACA8FC19 for ; Fri, 17 Dec 2010 14:19:28 +0000 (UTC) Received: from lion.home.serebryakov.spb.ru (89.112.15.178.pppoe.eltel.net [89.112.15.178]) (Authenticated sender: lev@serebryakov.spb.ru) by ftp.translate.ru (Postfix) with ESMTPA id 1692713DF42 for ; Fri, 17 Dec 2010 17:19:27 +0300 (MSK) Date: Fri, 17 Dec 2010 17:19:25 +0300 From: Lev Serebryakov X-Priority: 3 (Normal) Message-ID: <301293893.20101217171925@serebryakov.spb.ru> To: freebsd-geom@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable Cc: Subject: sys/kern/subr_disk.c and sys/geom/sched/subr_disk.c - is it intentional now? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 14:19:29 -0000 Hello, Freebsd-geom. I've found, that these two files doesn't have any differencr but function names & one diaganostic function in "generic" version. Is it intentional or it is artefact of times when "geom_sched" was experemental code? No comments in "geom_sched-private" version is givent and it seems as copy'n'paste which is dangerous -- for example, any changes in one file should be transferred into other (or not?). Explanation of this situation in header of sys/geom/sched/subr_disk.c is good idea, IMHO. --=20 // Black Lion AKA Lev Serebryakov