From owner-freebsd-bugs@FreeBSD.ORG Mon Mar 31 18:10:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5491C1065672 for ; Mon, 31 Mar 2008 18:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2B0108FC21 for ; Mon, 31 Mar 2008 18:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2VIA26w096683 for ; Mon, 31 Mar 2008 18:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2VIA1jO096682; Mon, 31 Mar 2008 18:10:02 GMT (envelope-from gnats) Resent-Date: Mon, 31 Mar 2008 18:10:02 GMT Resent-Message-Id: <200803311810.m2VIA1jO096682@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Harald Schmalzbauer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A0AD106566B for ; Mon, 31 Mar 2008 18:00:10 +0000 (UTC) (envelope-from harry@omnisec.de) Received: from host.omnisec.de (host.omnisec.de [62.245.232.135]) by mx1.freebsd.org (Postfix) with ESMTP id C4FE78FC17 for ; Mon, 31 Mar 2008 18:00:09 +0000 (UTC) (envelope-from harry@omnisec.de) Received: from tek.flintsbach.schmalzbauer.de (tek.flintsbach.schmalzbauer.de [172.21.2.3]) by host.omnisec.de (8.13.8/8.13.8) with ESMTP id m2VI02WV008086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 31 Mar 2008 20:00:08 +0200 (CEST) (envelope-from harry@titan.flintsbach.schmalzbauer.de) Received: from titan.flintsbach.schmalzbauer.de (titan.flintsbach.schmalzbauer.de [IPv6:fec0::1:0:0:1:1]) by tek.flintsbach.schmalzbauer.de (8.13.8/8.13.8) with ESMTP id m2VI02ii020197 for ; Mon, 31 Mar 2008 20:00:02 +0200 (CEST) (envelope-from harry@titan.flintsbach.schmalzbauer.de) Received: (from harry@localhost) by titan.flintsbach.schmalzbauer.de (8.14.2/8.14.2/Submit) id m2VI027F034877; Mon, 31 Mar 2008 20:00:02 +0200 (CEST) (envelope-from harry) Message-Id: <200803311800.m2VI027F034877@titan.flintsbach.schmalzbauer.de> Date: Mon, 31 Mar 2008 20:00:02 +0200 (CEST) From: Harald Schmalzbauer To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: misc/122300: SEPARATE_LIVEFS arch dependent set but unclear X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harald Schmalzbauer List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2008 18:10:02 -0000 >Number: 122300 >Category: misc >Synopsis: SEPARATE_LIVEFS arch dependent set but unclear >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Mon Mar 31 18:10:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Harald Schmalzbauer >Release: FreeBSD 7.0-STABLE i386 >Organization: OmniSEC >Environment: System: FreeBSD titan.flintsbach.schmalzbauer.de 7.0-STABLE FreeBSD 7.0-STABLE #1: Thu Mar 27 09:36:49 CET 2008 root@titan.flintsbach.schmalzbauer.de:/usr/obj/usr/src/sys/TITAN i386 >Description: In release/Makefile for all target architectures besides sparc64 SEPARATE_LIVEFS ist defined without true or false and evaluated by ifdef. So at a fisrt look it seems SEPARATE_LIVEFS ist _not_ set, but a closer look shows the opposite. I don't know why LIVEFS is not on disc1 by default any more, but making that more clear by setting SEPARATE_LIVEFS to true may help some peaople not too familar with release process. >How-To-Repeat: Watch line 195 in src/release/Makefile an the corresponding evaluation in line 267, 494 with 498, 970 and 1056 >Fix: The following patch has no functional change but makes the setting more obvious: --- src/release/Makefile.orig 2008-03-31 19:49:09.000000000 +0200 +++ src/release/Makefile 2008-03-31 19:49:53.000000000 +0200 @@ -192,7 +192,7 @@ .undef MAKE_FLOPPIES .if ${TARGET_ARCH} == "i386" MAKE_FLOPPIES= true -SEPARATE_LIVEFS= +SEPARATE_LIVEFS= true SPLIT_MFSROOT= .if ${TARGET} == "pc98" SMALLFLOPPYSIZE= 1200 @@ -218,7 +218,7 @@ MFSSIZE= 8192 MFSINODE= 8192 MFSLABEL= auto -SEPARATE_LIVEFS= +SEPARATE_LIVEFS= true .elif ${TARGET_ARCH} == "amd64" MAKE_FLOPPIES= true FLOPPYSIZE= 1440 @@ -229,14 +229,14 @@ MFSSIZE= 4096 MFSINODE= 8192 MFSLABEL= auto -SEPARATE_LIVEFS= +SEPARATE_LIVEFS= true SPLIT_MFSROOT= .elif ${TARGET_ARCH} == "powerpc" DISKLABEL= "" MFSSIZE= 4096 MFSINODE= 8192 MFSLABEL= auto -SEPARATE_LIVEFS= +SEPARATE_LIVEFS= true .endif .if defined(NO_FLOPPIES) .undef MAKE_FLOPPIES >Release-Note: >Audit-Trail: >Unformatted: