From owner-svn-src-head@freebsd.org  Thu Jun  1 20:06:06 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 593CDB7DD3C;
 Thu,  1 Jun 2017 20:06:06 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 34BDB661AC;
 Thu,  1 Jun 2017 20:06:06 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 4DC3361B1; Thu,  1 Jun 2017 20:06:05 +0000 (UTC)
Date: Thu, 1 Jun 2017 20:06:05 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
Cc: Marcel Moolenaar <marcel@FreeBSD.org>,
 Brooks Davis <brooks@FreeBSD.org>, svn-src-all@FreeBSD.org,
 "Simon J. Gerraty" <sjg@juniper.net>,
 src-committers <src-committers@FreeBSD.org>,
 svn-src-head@FreeBSD.org, Ngie Cooper <ngie@FreeBSD.org>
Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests
Message-ID: <20170601200605.GA66626@FreeBSD.org>
References: <201705310801.v4V81CjO004032@repo.freebsd.org>
 <20170601050339.GA48398@spindle.one-eyed-alien.net>
 <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com>
 <84744.1496336318@kaos.jnpr.net> <20170601171642.GA601@FreeBSD.org>
 <EB38926C-C27C-4404-A1C4-69BC8525A00C@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <EB38926C-C27C-4404-A1C4-69BC8525A00C@gmail.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2017 20:06:06 -0000

On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote:
> ...
> I vote for not checking in the SHAs. If something fails (as someone else
> mentioned on the lists), it's really hard to debug why it failed.

Like I've said, it's not "really" hard.  Check out previous version and
generate image with correct hash, there is no strong reason to commit the
image other than minor usability improvement of not having to check out
previous version.

Then again, just my $.02 -- I'm not the one doing actual work here.

./danfe