From owner-freebsd-hackers@FreeBSD.ORG Mon Oct 12 09:57:11 2009 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE63D1065672 for ; Mon, 12 Oct 2009 09:57:11 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 85D1F8FC0C for ; Mon, 12 Oct 2009 09:57:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 674C014D984A; Mon, 12 Oct 2009 11:57:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at example.com Received: from server.mypc.hu ([127.0.0.1]) by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9wXHLPhPNEEQ; Mon, 12 Oct 2009 11:57:08 +0200 (CEST) Received: from [192.168.1.105] (catv-89-132-179-104.catv.broadband.hu [89.132.179.104]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id DE70014D9843; Mon, 12 Oct 2009 11:57:07 +0200 (CEST) Message-ID: <4AD2FD6E.8090208@FreeBSD.org> Date: Mon, 12 Oct 2009 11:57:02 +0200 From: Gabor Kovesdan User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Ed Schouten References: <20091011145021.GG36937@acme.spoerlein.net> <20091011170918.GU71731@hoeg.nl> In-Reply-To: <20091011170918.GU71731@hoeg.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: FreeBSD Hackers Subject: Re: RFC: Big Makefile patch for WARNS settings X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2009 09:57:11 -0000 Ed Schouten escribió: > Hi Ulrich, > > * Ulrich Spörlein wrote: > >> Comments? Committers? >> > > Wouldn't it better to address the root of the problem while there? ;-) > What I noticed is that the patch sets WARNS?=0 for a lot of utilities, which actually have higher WARNS-compliance. Even if we don't "address the root of the problem" right now, it would be nice to elaborate and set each WARNS level at the higher value possible.For example, usr.bin/ul is marked as 0 by the patch but it seems to me it is WARNS=6 clean. I don't know the last sources, though, but I'm sure it will compile with at least WARNS=3. -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org