Date: Fri, 5 May 2006 16:57:38 +0300 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: "Andrew Pantyukhin" <infofarmer@gmail.com> Cc: FreeBSD Ports <ports@freebsd.org>, Sam Lawrance <lawrance@freebsd.org> Subject: Re: sourceforge subdir default Message-ID: <20060505165738.1965f74f@it.buh.cameradicommercio.ro> In-Reply-To: <cb5206420605050650j71bb7c81scd2bdba0a80823ca@mail.gmail.com> References: <cb5206420602180112k135e0569o360f02aad4fd4b0b@mail.gmail.com> <127FEBDA-4446-47DB-B6CA-4AB6A5CE8562@FreeBSD.org> <cb5206420604270827r2c03fbacx9e391a3e9489398@mail.gmail.com> <20060428003008.19f61dbc@it.buh.tecnik93.com> <cb5206420605050650j71bb7c81scd2bdba0a80823ca@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 5 May 2006 17:50:37 +0400
"Andrew Pantyukhin" <infofarmer@gmail.com> wrote:
> On 4/28/06, Ion-Mihai Tetcu <itetcu@people.tecnik93.com> wrote:
> > On Thu, 27 Apr 2006 19:27:38 +0400
> > "Andrew Pantyukhin" <infofarmer@gmail.com> wrote:
> > > Okay, I wonder if we can set M_S_SUBDIR to PORTNAME
> > > by default no matter what MASTER_SITES we have. I mean
> > > if there's a %SUBDIR% to replace, PORTNAME seems to be
> > > a reasonable default value, doesn't it?
> >
> > I've been thinking about the same thing for some time.
> >
> > Care to provide:
> > a) patch for b.p.m
> > b) patch for affected ports where this is true
> > ( c) the rest of M_S_SF ports should work w/o modifications ) ?
> >
> > I'll do a test for all the affected ports.
>
> % find /usr/ports -iname Makefile\* -exec egrep -H
> '^MASTER_SITE_SUBDIR=[[:space:]]*\$\{PORTNAME\}$' {} + | wc -l
> 1357
>
> So I think I won't provide a patch for the ports, we'll do patching
> step-by-step later (in the manner of USE_REINPLACE deprecation)
>
> Attached is a very simple diff. Even without any testing, I don't see
> how it can break anything at all. I'll submit a pr some time later.
I'll run a (partial) test tonight or tomorrow; first step would be to
find for how many ports this default is true and if we shouldn't rather
set a default for each MASTER_SITE_*
--
IOnut
Unregistered ;) FreeBSD "user"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060505165738.1965f74f>