From owner-svn-src-head@freebsd.org Fri Jan 5 18:03:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75506EB745B for ; Fri, 5 Jan 2018 18:03:55 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 009AC758F4 for ; Fri, 5 Jan 2018 18:03:55 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x232.google.com with SMTP id a79so3925697wma.0 for ; Fri, 05 Jan 2018 10:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=aE3q1XdywvaG2+ckibxZh2Hm4Nccj2mSJkBndLT8qCI=; b=APqEvZqzUPNZyO1Cw0Khfe4cfdXQw0eovwHsdPsvkOtTDegGOlLoat8Fm7WQF5eUyt Tkwlh5sJ4Rt0Ex9BF5Lmmsswxt8ANcPTsoDUt0fI+rXRcvJKWHXI8ye7VgGxE+ZFhOf9 n6n/JDadNeTC5PvjYFtOwcI9A7CS7JBgmiAD7dIjS4ogsR/QN6TmCbMqiSZ1tAiGLhLt mCCB4rfp6jY364JYaD4/2WPRMNd7F9YVOcM/v1mvsk2OUPJ/UVyKE0C80Le+L+6Bc1Fn ygHg0cbqd4onDmq3TgZM31wpsEaTyz8r2I5boDlg/R9VDd/U+mRZuWUPCyq/2MwnO9i+ kUlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=aE3q1XdywvaG2+ckibxZh2Hm4Nccj2mSJkBndLT8qCI=; b=dPi3yUYwHLqypgLxBuzP9fl7Vh7ZFkvOzavXr+hraJdUIn6M3zXySA3ekzHJgz+ktW Zhn7VZyh5qAv/EYfv4swRUXRv/XChDS2PV1urwibh5jpsPjtr6kfgpKsiJ6nmN2/hhgT BEHPJVhM61P31rPbwdCunbMzWBP6FjWerI/JZq8LMTAqwvEDc1UrOYMxDw9YQIgvmEVr A30rdQHIj7ZOBVi1tEwXucFdXAB2tJWM0/62LM5vCKgKXZN/CY3p/qWYBhrQZdbZJeAd VCe1D+OjQc2Qx0DJilqqs5moDrA9BWeyCscDikqhzPbmwt+7CPKMU+W41eFOpz/eGpR+ 9l4w== X-Gm-Message-State: AKGB3mI6opS+dX20M2sbkV4EHYKmZxOCejfER548DgaP3U3MbDlFTJHy I8xqJ9raH93jPtn5r//G50oOpPprFXk= X-Google-Smtp-Source: ACJfBouF7c/BroBKdOscenw4yrftRoDbDg8K2fu3LKzcM5z0bx0+z/bNZzX1xb24AiTHspAI0237xw== X-Received: by 10.80.225.195 with SMTP id m3mr5329762edl.222.1515175432983; Fri, 05 Jan 2018 10:03:52 -0800 (PST) Received: from [10.10.1.111] ([185.97.61.1]) by smtp.gmail.com with ESMTPSA id y1sm4250290edl.39.2018.01.05.10.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2018 10:03:52 -0800 (PST) Subject: Re: svn commit: r327559 - in head: . sys/net To: Eugene Grosbein , hiren panchasara Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801042005.w04K5liB049411@repo.freebsd.org> <5A4E9397.9000308@grosbein.net> <20180104224214.GD18879@strugglingcoder.info> <63c3c450-aeaf-bdd5-5e16-414146c9bb3a@multiplay.co.uk> <20180105094126.GE18879@strugglingcoder.info> <1854b421-3c09-c040-ba86-738b9c621eae@multiplay.co.uk> <5A4FB0B2.5070108@grosbein.net> From: Steven Hartland Message-ID: <4a3927f8-1ea8-36be-2fbd-e0ddc31563df@multiplay.co.uk> Date: Fri, 5 Jan 2018 18:03:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5A4FB0B2.5070108@grosbein.net> Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 18:03:55 -0000 On 05/01/2018 17:06, Eugene Grosbein wrote: > 05.01.2018 23:11, Steven Hartland wrote: > >> What do others think, am I missing something? > You still consider only TCP case missing IP forwarning case when all IP packets > are transit coming from lagg0 and going out via lagg1. Just going out via a laggX > > IP forwarding case benefits from pre-computed RSS flowid since 8.0-RELEASE > and your change breaks it. Is there a way to determine if the mbuf is a forwarded mbuf of not? I know I've said it before but just to be totally clear, changing the default was done to prevent broken behavior, if you're not concerned about the issue or you know you're not effected you can enable use_flowid to restore the original behavior. This doesn't have to be the final fix, if there are improvements that can be made to make the default more intelligent for example and use flowid if its known to be good then that can be looked into. In the mean time the new "default" will prevent others from configuring lagg(4) with LACP or loadbalance and ending up with problems; yes this may mean that IP forwarding in HEAD will use manual hashing hence will perform a little worse for now but that's the lesser of two evils.     Regards     Steve