Date: Wed, 6 Dec 2017 09:37:37 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r316980 - head/contrib/zstd/programs Message-ID: <20171206083736.mdodca65vr7xkc6g@ivaldir.net> In-Reply-To: <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> <CAG6CVpUCOUgT2S7MJXkingRmP04tgWehcE=v8R-casp8QsjTdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--xeg3w23sysplxwj6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 05, 2017 at 05:17:22PM -0800, Conrad Meyer wrote: > Ping. Please revert this change. If you want zstd to behave this > way, pursue it upstream first. This is planned, for now I first need to modify newsyslog to accept more arguments for the compression program, then I'll switch back zstd to a vani= lla. I am not pushing into the direction of yet another hardlink >=20 > Thanks, > Conrad >=20 > On Wed, Nov 15, 2017 at 7:38 PM, Conrad Meyer <cem@freebsd.org> wrote: > > Please revert this change. > > > > First, it introduces the POLA-violating behavior that zstdcat deletes > > its source files. This is not how zcat/bzcat behaves. > > > > Second, it introduces a needless behavioral difference between FreeBSD > > zstd and the rest of the world's zstd. The zstd documentation we ship > > continues to claim that zstd preserves source files by default, yet > > this change makes that documentation exactly backwards. While we can > > change FreeBSD's documentation to accommodate the change, we can't > > change Google results. > > > > Thanks, > > Conrad > > > > On Sat, Apr 15, 2017 at 1:15 PM, Baptiste Daroussin <bapt@freebsd.org> = wrote: > >> Author: bapt > >> Date: Sat Apr 15 20:15:44 2017 > >> New Revision: 316980 > >> URL: https://svnweb.freebsd.org/changeset/base/316980 > >> > >> Log: > >> Change some default to make zstd a dropin replacement for gzip,bzip = etc > >> in most cases > >> > >> Changes ares: > >> - quiet by default > >> - remove the source files one compression completion by default > >> > >> Modified: > >> head/contrib/zstd/programs/fileio.c > >> head/contrib/zstd/programs/zstdcli.c > >> > >> Modified: head/contrib/zstd/programs/fileio.c > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/contrib/zstd/programs/fileio.c Sat Apr 15 20:06:24 2017 = (r316979) > >> +++ head/contrib/zstd/programs/fileio.c Sat Apr 15 20:15:44 2017 = (r316980) > >> @@ -138,7 +138,7 @@ static U32 g_dictIDFlag =3D 1; > >> void FIO_setDictIDFlag(unsigned dictIDFlag) { g_dictIDFlag =3D dictID= Flag; } > >> static U32 g_checksumFlag =3D 1; > >> void FIO_setChecksumFlag(unsigned checksumFlag) { g_checksumFlag =3D = checksumFlag; } > >> -static U32 g_removeSrcFile =3D 0; > >> +static U32 g_removeSrcFile =3D 1; > >> void FIO_setRemoveSrcFile(unsigned flag) { g_removeSrcFile =3D (flag>= 0); } > >> static U32 g_memLimit =3D 0; > >> void FIO_setMemLimit(unsigned memLimit) { g_memLimit =3D memLimit; } > >> > >> Modified: head/contrib/zstd/programs/zstdcli.c > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:06:24 20= 17 (r316979) > >> +++ head/contrib/zstd/programs/zstdcli.c Sat Apr 15 20:15:44 20= 17 (r316980) > >> @@ -61,7 +61,7 @@ > >> #define MB *(1 <<20) > >> #define GB *(1U<<30) > >> > >> -#define DEFAULT_DISPLAY_LEVEL 2 > >> +#define DEFAULT_DISPLAY_LEVEL 1 > >> > >> static const char* g_defaultDictName =3D "dictionary"; > >> static const unsigned g_defaultMaxDictSize =3D 110 KB; > >> --xeg3w23sysplxwj6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlonrEkACgkQY4mL3PG3 PlolXQ//fPBTzL5yexhQgfE5o2CeGpw1TkvVZVo6u9reDHwpy1n56RNdSixy5KK6 ixoAQHx4AvHjphR7Bkp1IBiWS8M1KaDK+mzCievc47CRLzBwNkOqTu7ujoe2f7WU 2l50DZ+U38SgnYvJMmA6W7b2GvY1NzmVgLXU06jZu4GajqegyKeqcgtwGkKcdfHP 8ATALsMW7U1ECTeqifokoOdE6xQ2lUxSZiPMt6xCIx2c342B2y3iHVWd9oBq/K78 o3KwqW/48pvXWeSOqFehPNr2zXlGgCaW/u+qH9nxiC8jloP3nnKNqFE6up+yFl3L LwDoEzAPVS6/PWmJfo53VmwuDpbZE9ddRnHhYj2aJhIGymSb1UpixGs3a4/Fx2/t TaElSab8TedoO0BPvSKYXPoz+GFi3hwwmH5xw8cHt4YmVoCmzz/mv7EQw7+ptj9q ZN9d3iO26muQfmQSOYol0x+xKY1aMyajnnsohxLRtogT0R40zzXW0zbktbtE1Ty/ nZAtXZfKQeyJCmR6cgEahmGUywRaOnDmF2vYJ2qcEjgCYE4hh4kNmRDB1sdrcyKa XZ2gnWhQkTFn+mMz1UQBIa2lJsF4XuBPLGb+UDp8yBwJZEm090BWoZtnC6RXIK5c z9jMyoiEQsmzP159j+d2kDhHCvFX+h0R1y9zvJ5NrS+Vp2uj6nw= =Sr+k -----END PGP SIGNATURE----- --xeg3w23sysplxwj6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171206083736.mdodca65vr7xkc6g>