Date: Wed, 30 Aug 2017 09:31:00 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448936 - in head/cad/stepcode: . files Message-ID: <20170830093100.GA32914@FreeBSD.org> In-Reply-To: <201708291936.v7TJaH4W097098@repo.freebsd.org> References: <201708291936.v7TJaH4W097098@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 29, 2017 at 07:36:16PM +0000, Kurt Jaeger wrote: > New Revision: 448936 > URL: https://svnweb.freebsd.org/changeset/ports/448936 > > Log: > cad/stepcode: Fix portlint issues > > PR: 221835 > ... > CMAKE_ARGS+= -DSC_INSTALL_PREFIX=${PREFIX} \ > -DSC_BUILD_TYPE=Release > + > +MANDIRS= ${PREFIX}/man What does this variable do? I don't see it referenced anywhere. Looks like someone tried to play pass MAN_DIR down to cmake, but failed to do it properly (see below). > @@ -0,0 +1,11 @@ > +--- doc/CMakeLists.txt.orig 2017-08-29 15:56:46 UTC > ++++ doc/CMakeLists.txt > +@@ -4,7 +4,7 @@ set(sc_MANS > + ) > + > + if(NOT DEFINED MAN_DIR) > +- set(MAN_DIR share/man) > ++ set(MAN_DIR man) > + endif(NOT DEFINED MAN_DIR) Why to patch it when you can pass MAN_DIR via CMAKE_ARGS (together with other values)? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170830093100.GA32914>