From owner-cvs-all  Tue May 29 23:22:58 2001
Delivered-To: cvs-all@freebsd.org
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65])
	by hub.freebsd.org (Postfix) with ESMTP
	id 20D9137B422; Tue, 29 May 2001 23:22:43 -0700 (PDT)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f4U6MY750342;
	Wed, 30 May 2001 09:22:34 +0300 (EEST)
	(envelope-from ru)
Date: Wed, 30 May 2001 09:22:34 +0300
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Warner Losh <imp@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c
Message-ID: <20010530092234.B32934@sunbay.com>
Mail-Followup-To: Warner Losh <imp@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
References: <200105291841.f4TIfHJ95818@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200105291841.f4TIfHJ95818@freefall.freebsd.org>; from imp@FreeBSD.org on Tue, May 29, 2001 at 11:41:16AM -0700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, May 29, 2001 at 11:41:16AM -0700, Warner Losh wrote:
> imp         2001/05/29 11:41:16 PDT
> 
>   Modified files:
>     usr.bin/xinstall     xinstall.c 
>   Log:
>   Use use ${INSTALL} -d in our build process.  If INSTALL is set to
>   "install -C" then things will fail due to new checks.  Relax the
>   checks so that install -C -d works again.
>   
>   Revision  Changes    Path
>   1.42      +2 -2      src/usr.bin/xinstall/xinstall.c
> 
Argh, couldn't this have waited before I speak up?  :-(

I'm strongly objecting to this change and require it to be backed out.
Having INSTALL="install -C" is a bug, see usage() and SYNOPSIS before
my change, for example on 4.3-STABLE system.  It was a bug in the code
that this combination was allowed.  -C is to be used only with files,
not when installing directories (-d).

Moreover, relaxing the check for -S (safecopy), which is a new flag,
is bogus.

Are we required to support old bugs?


Cheers,
-- 
Ruslan Ermilov		Oracle Developer/DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message