Date: Wed, 12 Nov 2003 10:53:34 -0800 (PST) From: Sam Leffler <sam@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 42147 for review Message-ID: <200311121853.hACIrYj0008298@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=42147 Change 42147 by sam@sam_ebb on 2003/11/12 10:53:06 don't count PHY errors as input errors; it's too confusing and doesn't properly reflect network traffic Affected files ... .. //depot/projects/netperf/sys/dev/ath/if_ath.c#33 edit Differences ... ==== //depot/projects/netperf/sys/dev/ath/if_ath.c#33 (text+ko) ==== @@ -1633,7 +1633,6 @@ break; TAILQ_REMOVE(&sc->sc_rxbuf, bf, bf_list); if (ds->ds_rxstat.rs_status != 0) { - ifp->if_ierrors++; if (ds->ds_rxstat.rs_status & HAL_RXERR_CRC) sc->sc_stats.ast_rx_crcerr++; if (ds->ds_rxstat.rs_status & HAL_RXERR_FIFO) @@ -1644,6 +1643,15 @@ sc->sc_stats.ast_rx_phyerr++; phyerr = ds->ds_rxstat.rs_phyerr & 0x1f; sc->sc_stats.ast_rx_phy[phyerr]++; + } else { + /* + * NB: don't count PHY errors as input errors; + * we enable them on the 5212 to collect info + * about environmental noise and, in that + * setting, they don't really reflect tx/rx + * errors. + */ + ifp->if_ierrors++; } goto rx_next; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311121853.hACIrYj0008298>