From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 19 06:20:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CA861065676 for ; Thu, 19 Jun 2008 06:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 725D08FC26 for ; Thu, 19 Jun 2008 06:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5J6K2mN060316 for ; Thu, 19 Jun 2008 06:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5J6K20O060315; Thu, 19 Jun 2008 06:20:02 GMT (envelope-from gnats) Resent-Date: Thu, 19 Jun 2008 06:20:02 GMT Resent-Message-Id: <200806190620.m5J6K20O060315@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yuri Skripachov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19707106564A for ; Thu, 19 Jun 2008 06:10:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 118738FC20 for ; Thu, 19 Jun 2008 06:10:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5J6ASdj009049 for ; Thu, 19 Jun 2008 06:10:28 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m5J6AScn009048; Thu, 19 Jun 2008 06:10:28 GMT (envelope-from nobody) Message-Id: <200806190610.m5J6AScn009048@www.freebsd.org> Date: Thu, 19 Jun 2008 06:10:28 GMT From: Yuri Skripachov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/124744: incorrect _BST result validation for Tosh Satellite P20 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jun 2008 06:20:02 -0000 >Number: 124744 >Category: misc >Synopsis: incorrect _BST result validation for Tosh Satellite P20 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jun 19 06:20:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Yuri Skripachov >Release: FreeBSD 7.0-STABLE >Organization: >Environment: FreeBSD satellite.local 7.0-STABLE FreeBSD 7.0-STABLE #0: Wed Jun 18 13:50:25 MSD 2008 yvs@satellite.local:/usr/local/obj/usr/src/sys/SATELLITE i386 >Description: "acpiconf -i 0" command does not show battery presence if notebook is AC powered. that is because of extra bits used in _BST state by toshiba. according to acpi specs the only wrong _BST state is (ACPI_BATT_STAT_CHARGING | ACPI_BATT_STAT_DISCHARG). it seems that other bits in _BST have to be ignored and arithmetic comparison is a wrong way to validate _BST state. at least for my satellite :( i have been using this patch for 5.x, 6.x and 7.0-stable. >How-To-Repeat: plug in AC adapter and type acpiconf -i 0. >Fix: patch for /usr/src/sys/dev/acpica/acpi_battery.c is attached. Patch attached with submission follows: --- acpi_battery.c.orig 2008-06-19 09:35:41.000000000 +0400 +++ acpi_battery.c 2008-06-19 09:36:05.000000000 +0400 @@ -101,8 +101,10 @@ int acpi_battery_bst_valid(struct acpi_bst *bst) { - return (bst->state < ACPI_BATT_STAT_MAX && bst->cap != ACPI_BATT_UNKNOWN && - bst->volt != ACPI_BATT_UNKNOWN); +#define ACPI_BATT_STAT_IMPOSSIBLE (ACPI_BATT_STAT_CHARGING | ACPI_BATT_STAT_DISCHARG) + return ((bst->state & ACPI_BATT_STAT_IMPOSSIBLE) != ACPI_BATT_STAT_IMPOSSIBLE && + bst->cap != ACPI_BATT_UNKNOWN && bst->volt != ACPI_BATT_UNKNOWN); +#undef ACPI_BATT_STAT_IMPOSSIBLE } /* Check _BIF results for validity. */ >Release-Note: >Audit-Trail: >Unformatted: