From nobody Mon Jul 27 23:11:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8DqG4tygz6m29M for ; Mon, 27 Jul 2026 23:11:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8DqG0C6Kz3L98 for ; Mon, 27 Jul 2026 23:11:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785193866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9QB5t6sOrC9wP1GS7YBoyoBY7P13QgsU4L1oUokWMjE=; b=kfbBipUTotTFeVF8NvkzyRzij4aiJPWWVrGXMubSOHqu2ivJKcfG7Wn06z2UEfw/Tt8syx PPQacn6U+/vb2L9SRLaEhKmgc9vRUo7K7ZMqOqfn27imJBcozlj93MKMv5IM9oo/vDN93l 6ERoQA8FYSHzj1sApV5dflVYxwMVLk6gfFe586MX7gKNtYDx5quNk2UD9eC6lD5uB3XtKx nShGs6FSrEnFEynBoNOv1IOx+ck4e7NtY3MzMhbJ3BGcDzah9bRQlIRALuDajpndKLPRbE E0zfkDV52quPR9ZLmZnYQ31tHqEfhyCf2ZVD217oWx/lR6cm3ktmWhJ6icXDOQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785193866; a=rsa-sha256; cv=none; b=E6CtIexcZJCzttpiOfwzuiBiU/JpniljwLCetAN9EID7nxihYB8U8YzUB6SibauPywfxCG uGCu6/yfo13r8YunxR0giCaHJt22oKgdNfRGrq0WaC6N1sDIfucn9qVxOumfQr7tFiHlvC 03xeseu0neuRpYUKvQGRf0rVnRnUI5opQL2RoIqf8cSXZmytKy1vlfvw1225QQ9USIAONm ZAha5lxLljD20ikXYbgM+kwvR8aAO82tYKCGXMMErv/wGbgi2rASMB8Pj9naPYOquIDj2v 3V8ZxSrAs5nmShLb6B91NqAJWODN5R1Xgo0zj/79unRMs8uIfQzQ6TPVhtRQrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785193866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9QB5t6sOrC9wP1GS7YBoyoBY7P13QgsU4L1oUokWMjE=; b=jNhz2VXJlF4+V2Z2qF68u+NRyi0yFy2LQQTfj3YpX0ujd8m5o8SPkjlIUEcrOCTsebQj/b gsyOnJ+jB3o8CzWN9NtpiasuSdcIp7I1f3wtG+2lSo/1VfqcdShB5PsRSc8I8Kz80bx6ra 25XLCcjw83iz3epEope+4EMJIxwspkJ40xcm0BCKLCDkiHGW11vANM0WcNycYHbyi/r7/Y uT8gAwELAmybMU89OL9zAypK1kd1ki2lx8MUTDvTMaWrVkfj+9THN+GoKOGJjDSljWEOyr ZCD66fqHXEVN2XOqD8WXyS6WJLfeVuEQe7tUQjz8GmHUzA18Egk4k/hBAsmLvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h8DqF6PcTz1SBK for ; Mon, 27 Jul 2026 23:11:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32768 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Jul 2026 23:11:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b02e02958dad - main - libfetch: Fix handling of connection failures List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b02e02958dad2d5ce3675cbc18b9a94635d09e66 Auto-Submitted: auto-generated Date: Mon, 27 Jul 2026 23:11:00 +0000 Message-Id: <6a67e584.32768.6fc20c11@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b02e02958dad2d5ce3675cbc18b9a94635d09e66 commit b02e02958dad2d5ce3675cbc18b9a94635d09e66 Author: Mark Johnston AuthorDate: 2026-07-27 18:58:34 +0000 Commit: Mark Johnston CommitDate: 2026-07-27 23:03:16 +0000 libfetch: Fix handling of connection failures After commit 848f360c8f9a, if one tries to connect to a closed port, fetch reports "Operation now in progress", which is rather confusing. Return a more useful error message, restoring the old behaviour. Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts") Reviewed by: des MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D58481 --- lib/libfetch/common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c index dabc8c4b16b3..8ae51d37481b 100644 --- a/lib/libfetch/common.c +++ b/lib/libfetch/common.c @@ -681,6 +681,10 @@ fetch_connect(const char *host, int port, int af, int verbose) delta.tv_usec / 1000; } } + if (pfd.revents & POLLHUP) { + errno = ECONNREFUSED; + break; + } if (pfd.revents == POLLOUT) { /* connection established */ err = 0;