From owner-cvs-all@FreeBSD.ORG  Mon Apr 19 23:23:10 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7BAC216A4CE; Mon, 19 Apr 2004 23:23:10 -0700 (PDT)
Received: from mtaw6.prodigy.net (mtaw6.prodigy.net [64.164.98.56])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6385143D53; Mon, 19 Apr 2004 23:23:10 -0700 (PDT)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(3b6bfb74a8b23443a3d564cd6810010d@adsl-67-115-73-128.dsl.lsan03.pacbell.net
	[67.115.73.128])
	by mtaw6.prodigy.net (8.12.10/8.12.10) with ESMTP id i3K6LxpT009249;
	Mon, 19 Apr 2004 23:21:59 -0700 (PDT)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 4A236511D0; Mon, 19 Apr 2004 23:23:09 -0700 (PDT)
Date: Mon, 19 Apr 2004 23:23:09 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: Kirill Ponomarew <krion@FreeBSD.org>
Message-ID: <20040420062308.GA54233@xor.obsecurity.org>
References: <200404200559.i3K5xVfh058842@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN"
Content-Disposition: inline
In-Reply-To: <200404200559.i3K5xVfh058842@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/lang/pnet-base Makefile ports/lang/pnetlib
	Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 06:23:10 -0000


--J/dobhs11T7y2rNN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 19, 2004 at 10:59:31PM -0700, Kirill Ponomarew wrote:
> krion       2004/04/19 22:59:31 PDT
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     lang/pnet-base       Makefile=20
>     lang/pnetlib         Makefile=20
>   Log:
>   - Fix IGNORE message
>   - Remove quotes

> |  .if ${ARCH} =3D=3D "alpha"
> | -BROKEN=3D		"cscc core dumps"
> | +BROKEN=3D		Coredump during build on alpha
> |  .endif

For these examples it was academic since they don't contain special
characters, but when they do then BROKEN needs to be quoted, and
IGNORE needs to be *not* quoted (because it is quoted internally by
bsd.port.mk).  I tried to repair this inconsistency a few weeks ago
because people (including myself) keep getting it wrong, but it was
hard to get all the cases to work and I haven't come back to it yet.

In the meantime it might be better to just remove all quotes from
IGNORE strings.

> |  .if ${ARCH} =3D=3D "alpha"
> | -IGNORE=3D		"cscc core dumps durring build"
> | +IGNORE=3D		Coredump during build on alpha
> |  .endif

My point here was that IGNORE does this:

=3D=3D=3D>  pnetlib-0.6.4 Coredump during build on alpha.

which is not a properly formed sentence.

Kris
--J/dobhs11T7y2rNN
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAhMHMWry0BWjoQKURAmU+AJ9jDulJmfDOSZSGKUb+MzzrAxPfIQCg3t5b
gF66wKrTS8wJXtPlvY5VdAU=
=C4zb
-----END PGP SIGNATURE-----

--J/dobhs11T7y2rNN--