From owner-svn-src-all@freebsd.org  Tue Jul 14 22:17:59 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D00B69A2032
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Tue, 14 Jul 2015 22:17:59 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound3.ore.mailhop.org (erouter6.ore.mailhop.org
 [54.187.213.119]) by mx1.freebsd.org (Postfix) with SMTP id B058A1C0F
 for <svn-src-all@freebsd.org>; Tue, 14 Jul 2015 22:17:58 +0000 (UTC)
 (envelope-from ian@freebsd.org)
Received: from ilsoft.org (unknown [73.34.117.227])
 by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA;
 Tue, 14 Jul 2015 22:16:23 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id t6EMHoqe050361;
 Tue, 14 Jul 2015 16:17:50 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1436912270.1334.309.camel@freebsd.org>
Subject: Re: svn commit: r285552 - head/usr.bin/xargs
From: Ian Lepore <ian@freebsd.org>
To: d@delphij.net
Cc: Garrett Cooper <yaneurabeya@gmail.com>, Baptiste Daroussin
 <bapt@FreeBSD.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Tue, 14 Jul 2015 16:17:50 -0600
In-Reply-To: <55A574BA.4090700@delphij.net>
References: <201507141916.t6EJGEG1083928@repo.freebsd.org>
 <48222CD1-7087-4C9A-A586-71F6A37A601C@gmail.com>
 <55A574BA.4090700@delphij.net>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2015 22:17:59 -0000

On Tue, 2015-07-14 at 13:44 -0700, Xin Li wrote:
> On 07/14/15 13:29, Garrett Cooper wrote:
> > On Jul 14, 2015, at 12:16, Baptiste Daroussin <bapt@FreeBSD.org>
> > wrote:
> > 
> >> Author: bapt Date: Tue Jul 14 19:16:14 2015 New Revision: 285552 
> >> URL: https://svnweb.freebsd.org/changeset/base/285552
> >> 
> >> Log: Convert atoi(3) to stronum(3) which allows to arguments and
> >> report proper errors to the users
> > 
> > Is strtonum preferred over strtoll, etc?
> 
> strtonum(3) is a wrapper of strtoll() and provides more functionality
> like range checking, so I think the answer would be yes.
> 
> Cheers,
> 

Except if we convert all our tools that take numbers on the command line
to use strtonum() then peoples' existing scripts and other automation
that passes 0xWhatever numbers suddenly stop working.  strtonum() seems
to be about 2/3 of a good idea.

-- Ian