From owner-svn-src-all@freebsd.org Wed Nov 9 05:27:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62230C37018; Wed, 9 Nov 2016 05:27:56 +0000 (UTC) (envelope-from lists.br@gmail.com) Received: from mail-yb0-x22b.google.com (mail-yb0-x22b.google.com [IPv6:2607:f8b0:4002:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33A0DED7; Wed, 9 Nov 2016 05:27:56 +0000 (UTC) (envelope-from lists.br@gmail.com) Received: by mail-yb0-x22b.google.com with SMTP id v78so75030982ybe.3; Tue, 08 Nov 2016 21:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Od0XO94SDrHTOH7iSXiphpSMQH8QVG/S7njPOFaFPtM=; b=0/l8nztiLJGNbWMubjNl2ahG9EnFUoDKwj1jkMxGyWmEl4eaKs6UzkfwFg4AFR2nUt 65oLXQQuvA19w9ckqgReIDUkYhIkvnCCr2Vl6AQBDunGjMashkV51ZUeaErU6VV+YzGK /qjr8WjWHcJiPBP8pnR9MU/w6eE1j32ZXd7kMDOD3OyPf4JvXcy+Q4mt5l70LUWBbAFD QijJMXwVJQM9ONNjAAR/kY23fTLil9aUCG/5QdU1wYj0/0UQTiJXXTaC3SkOCvNJRVpU zbP9eL+6/yqfS9J9XtNREM4WOWABhlb/1wz7JluBTsx1BTcB0eEH8Nu6TPcE0A57oK1F Ni/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Od0XO94SDrHTOH7iSXiphpSMQH8QVG/S7njPOFaFPtM=; b=eszmnAZn1hE+Io6hmF3sZbuLDo+Cex1Mz/Rg15mHaCFryVf8Qhxy1viQkg/THZYNUH uqkITG5cNSyOa6PMwWgY5h5cTJOLS3AvhMhGy3vEg3f5Bql5G/yGsEV0Z+1xh3s25NSO DIQoxpZI3izCxHGPvY8S1K0sw1XYVAM+xJCxiI1F/fbiJhOVL+t61WYfdtnLXAn4Zb94 RTS5Q1CAOgHyZiBWBztpPGUe+73SgrTG5v+ZoNOJMSwJCEoLQ8Sxt3MA0kdHZs1uX+G7 PWZ0Q1pEERjvAH0xhomqgjIwTceMtsJFVHpVi8zhiDBtNdToY/WwI33Yvotfi5TL+h3V jGyA== X-Gm-Message-State: ABUngvewDPJidprVnUpb/KENTDQ3bLWgwK9pL/YgTyYHFGZJGuw2PMvam8FX+Xu3E1NzZPhZ3PK5inlvklcELw== X-Received: by 10.37.0.137 with SMTP id 131mr16038742yba.87.1478669275260; Tue, 08 Nov 2016 21:27:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.162.88 with HTTP; Tue, 8 Nov 2016 21:27:54 -0800 (PST) In-Reply-To: <20161109052656.76911ada273bb14048bb999b@bidouilliste.com> References: <201611090407.uA947Fnu065307@repo.freebsd.org> <20161109052656.76911ada273bb14048bb999b@bidouilliste.com> From: Luiz Otavio O Souza Date: Wed, 9 Nov 2016 03:27:54 -0200 Message-ID: Subject: Re: svn commit: r308458 - in head/sys: boot/fdt/dts/arm modules/dtb/am335x To: Emmanuel Vadot Cc: Luiz Otavio O Souza , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2016 05:27:56 -0000 On 9 November 2016 at 02:26, Emmanuel Vadot wrote: > On Wed, 9 Nov 2016 04:07:15 +0000 (UTC) > Luiz Otavio O Souza wrote: > >> Author: loos >> Date: Wed Nov 9 04:07:15 2016 >> New Revision: 308458 >> URL: https://svnweb.freebsd.org/changeset/base/308458 >> >> Log: >> Add the DTS for the Netgate SG-1000 (micro-Firewall). >> >> The SG-1000 boots with GENERIC ARM kernel on -head. >> >> Obtained from: pfSense >> Sponsored by: Rubicon Communications, LLC (Netgate) >> >> Added: >> head/sys/boot/fdt/dts/arm/ubmc.dtsi (contents, props changed) >> head/sys/boot/fdt/dts/arm/ufw.dts (contents, props changed) >> Modified: >> head/sys/modules/dtb/am335x/Makefile > > Hello Luiz, > > Two things: > > - If ubmc.dtsi is gnu licenced it shouldn't go in sys/boot/fdt/dts. > It shouldn't go to sys/gnu/dts too as it's not from upstream. > - I don't understand why you didn't use the am33xx.dtsi from > upstream, it is the way to go for dts. > > The correct way to add support for this board would be : > > 1) Create a ubmc.dtsi that uses upstream am33xx.dtsi and submit it > upstream (i.e. linux-arm), MIT/GPL dual licence > 2) Create a ufw.dts and also submit it upstream (also MIT/GPL) > 3) Since those are also MIT you could add them to sys/boot/fdt > 4) When we will update the dts from upstream you can then remove them > from sys/boot/fdt > > But there would still be a problem since the am33xx.dtsi is not MIT/GPL > licenced. > So I guess you don't have any other solution than dealing with DTS > somewhere in the pfsense repository (maybe with package or something). > > The DTS world is already a mess with it's licence and the fact that > linux is the "official" place, so please do not add more :) Hi Emmanuel, Yes, you're right. I forgot about the licence in this file. This is not an issue for us in pfSense (we do not depend on this change in FreeBSD), we want to provide support for the people that is going to use/test FreeBSD on uFW. As this is all our work, I'll redo the files and include our changes in a single file. FreeBSD is the upstream here, it is the first officially supported OS for uFW. Thanks, Luiz