From owner-svn-ports-head@FreeBSD.ORG  Sat Jan 25 09:20:55 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0124B907;
 Sat, 25 Jan 2014 09:20:55 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 459F31F52;
 Sat, 25 Jan 2014 09:20:54 +0000 (UTC)
Received: from [192.168.0.23] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 2502343B94;
 Sat, 25 Jan 2014 03:20:35 -0600 (CST)
Message-ID: <52E381D3.9020009@marino.st>
Date: Sat, 25 Jan 2014 10:20:19 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Martin Wilke <miwi.fbsd@gmail.com>
Subject: Re: svn commit: r340970 - head/devel/premake
References: <201401250043.s0P0h0RO021017@svn.freebsd.org>
 <20140125064631.GA96178@FreeBSD.org>
 <CAFY+yEnyBz0hb6y49iiHOjHSvy-WuoBuTW90+vm_6z9voFcJSw@mail.gmail.com>
In-Reply-To: <CAFY+yEnyBz0hb6y49iiHOjHSvy-WuoBuTW90+vm_6z9voFcJSw@mail.gmail.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>,
 Baptiste Daroussin <bapt@freebsd.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Jan 2014 09:20:55 -0000

On 1/25/2014 10:14, Martin Wilke wrote:
> And your commenting about style worries maintainer and committers so
> better reread last line in motd at freefall. 
> 
> thanks ;)
> 
> 
> On Sat, Jan 25, 2014 at 2:46 PM, Alexey Dokuchaev <danfe@freebsd.org
>     Ditto.  Guys, I know some of you are working on stagifying the tree very
>     actively these days, making tens to hundreds commits a day.  This is all
>     much appreciated, cool, and awesome, but it does not mean commit
>     messages
>     can become sloppy.  Moreover, it gives a bad example for other people.

I agree that Danfe is coming from a weak position since he's throwing
stones while living in a glass house (meaning he's got plenty on his
plate and I don't see many commits lately), however, that doesn't make
him wrong.

The majority of FreeBSD commit messages are atrocious, and that's
including when they meet the standard of danfe.  I just love seeing QAT
message that you can't immediately tell which port failed because only a
very few people (like myself) put the name of the port being changed in
the first line of the message.

The freebsd rationale for not doing it?  "The mail list added the port
name automatically so it's redundant".  Except that doesn't apply to QAT
or any external repository.  So big fail all already.

So he's right + he should get his house in order to avoid the "shut up;
you're guilty too" responses.

John