Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Oct 2012 14:16:18 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Andre Oppermann <andre@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r241923 - in head/sys: netinet netipsec
Message-ID:  <20121023101618.GP70741@FreeBSD.org>
In-Reply-To: <50865F60.4040409@freebsd.org>
References:  <201210230833.q9N8XEas020937@svn.freebsd.org> <50865F60.4040409@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 23, 2012 at 11:12:00AM +0200, Andre Oppermann wrote:
A> On 23.10.2012 10:33, Gleb Smirnoff wrote:
A> > Author: glebius
A> > Date: Tue Oct 23 08:33:13 2012
A> > New Revision: 241923
A> > URL: http://svn.freebsd.org/changeset/base/241923
A> >
A> > Log:
A> >      Do not reduce ip_len by size of IP header in the ip_input()
A> >    before passing a packet to protocol input routines.
A> >      For several protocols this mean that now protocol needs to
A> >    do subtraction itself, and for another half this means that
A> >    we do not need to add header length back to the packet.
A> 
A> Yay! More Mammoth shit getting washed away! ;)
A> 
A> Please add an entry to UPDATING as the convention of of ip_len
A> subtraction has been there since forever. That makes it easier
A> to discover for third parties writing code.

Not sure it worth. Never heard of any loadable protocol outside
of tree.

Those loadable protocols that we have in tree (carp, divert) do
not look at ip_len.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121023101618.GP70741>