From owner-freebsd-ports-bugs@freebsd.org Wed Oct 3 04:32:01 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03F6F10B778C for ; Wed, 3 Oct 2018 04:32:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 80A288B728 for ; Wed, 3 Oct 2018 04:32:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4595E10B778B; Wed, 3 Oct 2018 04:32:00 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32A0F10B778A for ; Wed, 3 Oct 2018 04:32:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4D228B727 for ; Wed, 3 Oct 2018 04:31:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 1FDA822540 for ; Wed, 3 Oct 2018 04:31:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w934Vw1e048315 for ; Wed, 3 Oct 2018 04:31:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w934VwKk048314 for ports-bugs@FreeBSD.org; Wed, 3 Oct 2018 04:31:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231770] databases/sqlite3: Add ICU flavor Date: Wed, 03 Oct 2018 04:31:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fsbruva@yahoo.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 04:32:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231770 Matt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197558|0 |1 is obsolete| | --- Comment #3 from Matt --- Created attachment 197729 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D197729&action= =3Dedit Add flavors - default, icu and mini I tested your patch tonight - and it behaved as I expected: users can de-se= lect the "ICU" option during `make config`. This is not appropriate. I looked more closely at the Makefile for editors/emacs, and emulated the u= se of OPTIONS_EXCLUDE to force the relevant build behavior for the icu and mini flavors. While attempting that, I completely re-organized the Makefile to conform to the guidance of [1], especially [2]. Following the major edit, I audited the two versions to ensure I hadn't missed anything. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options= .html --=20 You are receiving this mail because: You are the assignee for the bug.=