From owner-freebsd-current@FreeBSD.ORG Sat Jul 5 21:54:46 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83B761065676; Sat, 5 Jul 2008 21:54:46 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe15.swipnet.se [212.247.155.193]) by mx1.freebsd.org (Postfix) with ESMTP id B0ED08FC0A; Sat, 5 Jul 2008 21:54:45 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=pW5Z-H8n_VoA:10 a=_6_vb1nlnQcA:10 a=NMGBx6iLSXY/3qZKdJo9Bw==:17 a=6I5d2MoRAAAA:8 a=vPI1Uvfh2tOLLZd5LvAA:9 a=3B-JzkFH_HoxxIMzs3gA:7 a=u3MJIqfA3LGkk_pR_JBcSmJQSosA:4 a=lRjT1wxQ3FAA:10 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 Received: from [62.113.135.207] (account mc467741@c2i.net [62.113.135.207] verified) by mailfe15.swip.net (CommuniGate Pro SMTP 5.2.4b) with ESMTPA id 256148758; Sat, 05 Jul 2008 22:54:38 +0200 From: Hans Petter Selasky To: ticso@cicely.de Date: Sat, 5 Jul 2008 22:56:14 +0200 User-Agent: KMail/1.9.7 References: <20080703140719.GA72315@onelab2.iet.unipi.it> <200807050957.07900.hselasky@c2i.net> <20080705162426.GD41487@cicely7.cicely.de> In-Reply-To: <20080705162426.GD41487@cicely7.cicely.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200807052256.15792.hselasky@c2i.net> Cc: usb@freebsd.org, Luigi Rizzo , freebsd-current@freebsd.org, current@freebsd.org Subject: Re: may I commit this small umodem patch ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jul 2008 21:54:46 -0000 On Saturday 05 July 2008, Bernd Walter wrote: > On Sat, Jul 05, 2008 at 09:57:06AM +0200, Hans Petter Selasky wrote: > > On Saturday 05 July 2008, Luigi Rizzo wrote: > > > On Sat, Jul 05, 2008 at 12:28:47AM +0200, Hans Petter Selasky wrote: > > > > On Friday 04 July 2008, Luigi Rizzo wrote: > > > > > On Fri, Jul 04, 2008 at 11:33:15PM +0200, Hans Petter Selasky wro= te: > > > > > > On Thursday 03 July 2008, Luigi Rizzo wrote: > > > > > > > On Thu, Jul 03, 2008 at 05:07:00PM +0200, Gary Jennejohn wrot= e: > > > > > > > > On Thu, 3 Jul 2008 16:07:19 +0200 > > > > > > > > > > > > > > > > Luigi Rizzo wrote: > > > > > > > > > There was a discussion back in september about adding > > > > > > > > > support for basic CDC tty devices in umodem.c. > > > > > > > > > This lets you talk to a number of usb devices built around > > > > > > > > > microcontrollers (e.g. Atmel), and puts us on par with > > > > > > > > > Linux and Windows in terms of supporting these devices. > > > > > > > > > > > > > > > > > > Because this simply requires the small patch below to the > > > > > > > > > probe/attach routine, so if there are no objections I plan > > > > > > > > > to add this to the system (CURRENT then RELENG_7 and > > > > > > > > > RELENG_6) in the next few days. > > > > > > > > > > > > What about flow control? Is flow control required for these > > > > > > devices? > > > > > > > > > > the ones I am talking about don't implement any form of flow > > > > > control. I suppose they would otherwise match the previous check. > > > > > > > > > > luigi > > > > > > > > I mean, are you going to upload firmware through these interfaces? > > > > > > the OS only know about bytes. > > > > > > are firmware, software, data or random noise. > > > if you want to know whether the sam7 uploader works, yes it does. > > > _______________________________________________ > > > freebsd-current@freebsd.org mailing list > > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > > To unsubscribe, send any mail to > > > "freebsd-current-unsubscribe@freebsd.org" > > > > Yes, but you know that umodem can drop data, if the buffers overflow ? > > Do you mean the driver can loose data? > It would be good if this is avoidable somehow. > In fact those beasts have some kind of pseudo flow control in that they > don't ack further packets. > Basicly this is nothing more than using a pair of bulk pipes for raw > data, but under the hood of CDC identification. > I personally only use them for uploading firmware to AT91SAM7* > controllers, as luigi does, but since Windows and Linux have generic > drivers this is quite popular. =46rom what I know the TTY layer which umodem uses will dump data when the= =20 buffers are full. But it there is some kind of framing in the protocol used= ,=20 then this is no problem. =2D-HPS