From owner-svn-src-head@freebsd.org  Fri Apr  5 20:29:59 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B29F0155DA9D;
 Fri,  5 Apr 2019 20:29:59 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 23EF173C4F;
 Fri,  5 Apr 2019 20:29:58 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x35KTuEN041159;
 Fri, 5 Apr 2019 13:29:56 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x35KTuCo041158;
 Fri, 5 Apr 2019 13:29:56 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <201904052029.x35KTuCo041158@gndrsh.dnsmgr.net>
Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs
In-Reply-To: <FAF85814-991B-4D30-96AD-2B3D46E4E97F@gmail.com>
To: Enji Cooper <yaneurabeya@gmail.com>
Date: Fri, 5 Apr 2019 13:29:56 -0700 (PDT)
CC: rgrimes@freebsd.org, cem@freebsd.org, Ed Maste <emaste@freebsd.org>,
 Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 svn-src-head <svn-src-head@freebsd.org>
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 23EF173C4F
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.97 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.97)[-0.969,0]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 20:29:59 -0000

> On Apr 5, 2019, at 13:22, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> 
> >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste <emaste@freebsd.org> wrote:
> >>> 
> >>>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> >>>> 
> >>> 
> >>>>> +static const u_char dot_name[] = {
> >>>>> +     '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> >>>>> +static const u_char dotdot_name[] = {
> >>>>> +     '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> >>>>> +
> >>> 
> >>> They are all either '.' or ' ', the commas are just list separators.
> >>> IMO spaces after the commas would make it slightly easier to see.
> >> 
> >> Would it make sense to just use the normal string syntax for char
> >> array assignment?
> >> 
> >> static const u_char dot_name[11] = ".          ";
> >> static const u_char dotdot_name[11] = "..         ";
> >> 
> >> Seems more clear to me.
> > 
> > To try and end this thread, I already stated it was in review,
> > let me get a pointer to it, if you have comments please post
> > them there:
> > https://reviews.freebsd.org/D19829
> 
> It would probably be a good idea to add a comment in the code to document the intention.
> Thanks,

Again, there is a review up, D19829, please comment there.

> -Enji
-- 
Rod Grimes                                                 rgrimes@freebsd.org