From owner-freebsd-audit Mon Jan 6 0:22: 0 2003 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AFEC37B405 for ; Mon, 6 Jan 2003 00:21:59 -0800 (PST) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FC9A43EC2 for ; Mon, 6 Jan 2003 00:21:57 -0800 (PST) (envelope-from keramida@freebsd.org) Received: from gothmog.gr (patr530-a233.otenet.gr [212.205.215.233]) by mailsrv.otenet.gr (8.12.6/8.12.6) with ESMTP id h068Ls4V017856 for ; Mon, 6 Jan 2003 10:21:55 +0200 (EET) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.6/8.12.6) with ESMTP id h068Lsbj001386 for ; Mon, 6 Jan 2003 10:21:54 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from giorgos@localhost) by gothmog.gr (8.12.6/8.12.6/Submit) id h068LspV001385 for freebsd-audit@freebsd.org; Mon, 6 Jan 2003 10:21:54 +0200 (EET) (envelope-from keramida@freebsd.org) Date: Mon, 6 Jan 2003 10:21:54 +0200 From: Giorgos Keramidas To: freebsd-audit@freebsd.org Subject: Re: hopefully, a fix for an old uncompress(1) bug Message-ID: <20030106082154.GE1094@gothmog.gr> References: <20030106062309.GA37109@gothmog.gr> <20030106080949.GA382@straylight.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030106080949.GA382@straylight.oblivion.bg> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2003-01-06 10:09, Peter Pentchev wrote: > On Mon, Jan 06, 2003 at 08:23:09AM +0200, Giorgos Keramidas wrote: > > diff -u -5 -r1.20 compress.c > > --- compress.c 28 Jul 2002 15:32:17 -0000 1.20 > > +++ compress.c 6 Jan 2003 06:15:06 -0000 > > @@ -298,26 +298,25 @@ > [snip] > > if ((ifp = zopen(in, "r", bits)) == NULL) { > > cwarn("%s", in); > > - goto err; > > + return; > > Is this change really needed? It is true that the code at 'err' would > be a no-op at this point, when neither ifp nor ofp has been opened, but > it strikes me as a bit more semantically correct to invoke the "real" > error-handling procedures at any error, just in case something changes > in the future and some error-handling does indeed become necessary. Probably not. I'm happy with any of them two versions. Your diff is even better since it reduces the changes to the absolute minimum. - Giorgos To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message