From owner-freebsd-net@freebsd.org Fri Feb 12 20:43:39 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2ED71530809 for ; Fri, 12 Feb 2021 20:43:39 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dclp224q7z3tws; Fri, 12 Feb 2021 20:43:37 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-pg1-x533.google.com with SMTP id t26so442278pgv.3; Fri, 12 Feb 2021 12:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jrjf86BFZVhremQW02OOVeoQrGwNEpSNIl/mkvwoK98=; b=dCVKQ/e3P6xNwEOxOsD+YMIY54wUvHA2CRKiEfioryHUG3CsiHMZj7LLegY3Uoy9Wt JB3ivF9XXYLKQ9Ax8mFwUZHifDshV2/K8iaRItL//inKlpT7iojOxrXh0iw60JNmRdHw Ti3W4lzBG7aJhGfu3Tu5pqB3bTThy2A4yaKEieUQExBJG1JCj/B5Cj3lMZZKr15egD8L bdYSav2+0pwGmgkJwOsTA43jG74xFi/sIl0lo1eVVupMwf7niLYlyegyev+DB6WfQKz3 0YX83axtZURoj7uYACda+OAUEcnOJXjj9iWErZ2Til6hcJ+Nkc/G8r7328YoOk6VhjM+ 9nuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jrjf86BFZVhremQW02OOVeoQrGwNEpSNIl/mkvwoK98=; b=h4IgoNIyxGt9rn422S/sJ5amXTSpd0qQPbv+Vkf5t4gGlhym95ohSmBiOyT875Mv2g HbRtbge/R7G+AhmVCvXrkTe9lojkm1aI3VVO7vHel+/bRawLnW1wfWBUDgnIr5i9F5hE znyBjp0JEcTe0T6WqJ4YAFXr3AKyll7rg3W8gKDWjpTsuh3n+nVVuEiqQmkuIY2NKvQi XfG++wK4GS9oM3/nfovuZEz+RoHvOHskqIppdSywcJjNgpTSkpNZwqTq5Y7CjXiOZ3ud 2+FkvfwPu4yqrPhOLuiNTyYZV1s9Dsmn35G0g/R9OVYmGc3peWlYw8h6cvEPho8tXQn1 Ko5w== X-Gm-Message-State: AOAM531s8F/2bmRfhO5ZLYjKLbwj4bpIWXWWYV/kueuNkiuUsLAtbU3R mUOcr8BBLeISSKPzNdBh7KuaLRnJoH2Tn+Ntb0KJUZ4BCR8O/w== X-Google-Smtp-Source: ABdhPJzFAanKQBZR1s1uX3QNixW15bvqT6BXKufImPPjLTfS3QK7n80UTcnPpmJQH8lftjtZsYpoXLdIwdw5n+pWOFo= X-Received: by 2002:aa7:8f0a:0:b029:1de:4d20:8346 with SMTP id x10-20020aa78f0a0000b02901de4d208346mr4738475pfr.15.1613162616599; Fri, 12 Feb 2021 12:43:36 -0800 (PST) MIME-Version: 1.0 References: <113921613153727@vla1-bff2c05bedc2.qloud-c.yandex.net> In-Reply-To: <113921613153727@vla1-bff2c05bedc2.qloud-c.yandex.net> From: Ryan Stone Date: Fri, 12 Feb 2021 15:43:25 -0500 Message-ID: Subject: Re: ifaddr reference count leaks that seem to be related to routing code To: "Alexander V. Chernikov" Cc: freebsd-net Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Dclp224q7z3tws X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=dCVKQ/e3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2607:f8b0:4864:20::533 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-3.98 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::533:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::533:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-0.98)[-0.977]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::533:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-net]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2021 20:43:39 -0000 Thanks! For reference, I tried this patch and it did resolve my leak: https://github.com/rysto32/freebsd/commit/73caa71c351c072d673d477972fda2aeb369eb3d I haven't exhaustively tested the routing code, though, so I can't say for certain that the assert will always be true, nor am I certain that no callers were depending on ifa_ref by rt_getifa_fib().