From owner-freebsd-current@FreeBSD.ORG Sun May 11 23:30:13 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4FC7DF51 for ; Sun, 11 May 2014 23:30:13 +0000 (UTC) Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1154C2FB0 for ; Sun, 11 May 2014 23:30:12 +0000 (UTC) Received: by mail-ig0-f171.google.com with SMTP id c1so3138241igq.4 for ; Sun, 11 May 2014 16:30:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=KEhoOQAMOsidX2UyZDUwmw1f7MNzfkTfAg3qTvgzkK8=; b=dOvzhArxbrQvybAypG1x/qeFFPSV6crtsal4J1VQixivmJmrFfujdWsTdXXpyNW0H5 UyPjCggQkaiuKk32/WdS1tJROKaGg1PddP3VmX7fBUNLeWrUIYs+hgpUV87DkYz0SICi vOVK+GH397gJo4PjOU+s9wpuaA1H2HgS1YfRhoie/BcxtG+Jbf0CLp9on9H+96Udx6od 6MhF37zPMP/RZvRJEQDmv/tmyWENVlKKal9wWgnBpAesVQzNp+CUWiZ7aA8cmIH9TPiD 8RafIH5OAmFZcz92CbEOChkIih7maEehGHCCX7HyYALiOIMXHmThHNt1LhekTRj3roe6 ud/A== X-Gm-Message-State: ALoCoQkaIDW3eC8OaakR8sHnZ5LSo/iMe5OD3bWLGHtN2bVhlBo0m/FcfT9DPnC7mUkqvt4I527Z X-Received: by 10.50.50.231 with SMTP id f7mr27042510igo.42.1399850529565; Sun, 11 May 2014 16:22:09 -0700 (PDT) Received: from netflix-mac.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id i16sm17513848igf.11.2014.05.11.16.22.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 11 May 2014 16:22:09 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_63013524-A5C5-4B4A-8A6B-0A08FEF6FF60"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 From: Warner Losh In-Reply-To: Date: Sun, 11 May 2014 17:22:07 -0600 Message-Id: <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <130417FC-CE39-43DE-B87F-DF2185FC94DC@bsdimp.com> To: Craig Rodrigues X-Mailer: Apple Mail (2.1874) Cc: freebsd-current Current , "jenkins-admin@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 May 2014 23:30:13 -0000 --Apple-Mail=_63013524-A5C5-4B4A-8A6B-0A08FEF6FF60 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 11, 2014, at 5:00 PM, Craig Rodrigues = wrote: > On Sun, May 11, 2014 at 3:25 PM, Warner Losh wrote: >>=20 >> On May 11, 2014, at 1:43 PM, Craig Rodrigues = wrote: >=20 >>> make[1]: = "/builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk" >>> line 24: Could not find ../../share/mk/bsd.mkopt.mk >=20 > Instead of explicitly specifying the path to "../../share/mk", > should some additional logic be added to respect > MAKESYSPATH? The only logic that can work is to test MAKESYSPATH and respect it if it = is defined, and use the relative path if not (since we don=92t require = MAKESYSPATH to be defined to do a out-of-tree module build, and could be = built on a system that isn=92t running the latest current). > Some people building products do build the kernel and modules out of = the > FreeBSD source tree, and put their mk files in a directory > which is not src/share/mk. That=92s not really a supported configuration. Using JIRA to force it is = rather an annoying use of JIRA since it makes making JIRA happy hard to = test and outside the normal work flow. This will cause pain in the = future, and I also object to my changes being characterized as =93wrong=94= when such a non-standard setup has never been explicitly supported, = required or part of anybody=92s normal workflow. Grump. I=92ve prepared a compromise commit, but I=92m not happy about it, and = think it is a horribly ugly kludge. But I can think of no other ways to = keep both use cases working. Warner --Apple-Mail=_63013524-A5C5-4B4A-8A6B-0A08FEF6FF60 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTcAYfAAoJEGwc0Sh9sBEAQVEQAMMKrYKtwrxN9JUq4D1G6gIQ E7xyxKkCLjvbQObAxGhi85aWat4t5x4BJEOjnADT9QGrWAxncYZER+Xinq5H2AiJ KB44lh3KPPfAmlxSE6+xfpCJAaALQc0owacsRNnEKlYLphZYbrJuNlndUYGXG+xz s2ofvUKqiR4pDP55MopDqPcxZyFZyyVDJkDrpDLJYDjRgjIWJVCs+rkUwxA8V6Fd tkb4nYP/3FfwuwoiUc914SIUGMgOh9yV6DCDxD9AqGByM4JfY8Ckk3QO70O02p53 KxLRcaJZThr+9K4B6tuHz6t24BbO1iUUE/ktg3Am8A1oFOIU2+j5cTVaa1874EgH SnINPdJ31zUADiOMBPejb15jpBcKDOrhUOm7zmHYdwnHR5cE166aU8KGanI9TjSR CvSm4SflreAKTkV7orMvg1MGFHE04I6bv9gCd/g6vVA/zA3cgOqzHMCTQxWyhRVJ 8+SPyf6R51c/X5SRF+isNs1OH3trFZuZBnjSqbovBlwN+DH98OFd1nP8c/+Xgjgo K+Jiyc7QsGH1GADr5cWq9kB1tyOTlNxtry5VzGVWtbN+ga28qaHIlVuQad3gLJCO TtyMo8czJUtpXgh+cYnLyT1A8oLIdSGQLbHsGhpypK5K42G/uRJMKJLZHi1i2osW d++f/cbwsVOO9zzRMEsp =6eCh -----END PGP SIGNATURE----- --Apple-Mail=_63013524-A5C5-4B4A-8A6B-0A08FEF6FF60--