From owner-freebsd-bugs  Sun May 18 12:50:27 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id MAA09097
          for bugs-outgoing; Sun, 18 May 1997 12:50:27 -0700 (PDT)
Received: from pluto.plutotech.com (root@pluto100.plutotech.com [206.168.67.137])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA09083
          for <freebsd-bugs@hub.freebsd.org>; Sun, 18 May 1997 12:50:22 -0700 (PDT)
Received: from narnia.plutotech.com (narnia.plutotech.com [206.168.67.130]) by pluto.plutotech.com (8.8.5/8.8.3) with ESMTP id NAA19710; Sun, 18 May 1997 13:50:20 -0600 (MDT)
Message-Id: <199705181950.NAA19710@pluto.plutotech.com>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
cc: freebsd-bugs@hub.freebsd.org
Subject: Re: kern/3618: getsockname and getpeername may cause trap 12 
In-reply-to: Your message of "Sun, 18 May 1997 12:10:01 PDT."
             <199705181910.MAA07376@hub.freebsd.org> 
Date: Sun, 18 May 1997 14:48:41 -0600
From: "Justin T. Gibbs" <gibbs@plutotech.com>
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> <<On Sun, 18 May 1997 15:08:52 +0200 (CEST), Tor Egge <Tor.Egge@idt.ntnu.no> 
>said:
> 
> > During the getsockname() or getpeername() call, a network interrupt
> > might reset the connection, causing the socket to no longer have a pcb.
> > If this happens at the wrong time, the system gets a trap 12.
> 
> This fix looks OK.  You have commit privs...

I think that the splnet() and perhaps the other initializers should be
broken appart from the declarations since, as I recall, he compiler can
re-order the initializations if it doesn't see any interdependancies.
It would also make it clearer exactly which actions need splnet protection.

--
Justin T. Gibbs
===========================================
  FreeBSD: Turning PCs into workstations
===========================================