From owner-freebsd-audit  Mon Jul 23 10:10:39 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from Veronica.wmol.com (veronica.wmol.com [208.242.83.241])
	by hub.freebsd.org (Postfix) with ESMTP id 2040337B401
	for <audit@freebsd.org>; Mon, 23 Jul 2001 10:10:33 -0700 (PDT)
	(envelope-from david@phobia.ms)
Received: from rain.hill.hom (081bc122.chartermi.net [24.247.81.122]) by Veronica.wmol.com
 (Vircom SMTPRS 4.6.189) with ESMTP id <B0008470811@Veronica.wmol.com>;
 Mon, 23 Jul 2001 13:07:57 -0400
Date: Mon, 23 Jul 2001 13:09:30 -0400
From: David Hill <david@phobia.ms>
To: Sheldon Hearn <sheldonh@starjuice.net>
Cc: audit@freebsd.org
Subject: Re: STD*_FILENO patches #2
Message-Id: <20010723130930.05f98c85.david@phobia.ms>
In-Reply-To: <3804.995906468@axl.seasidesoftware.co.za>
References: <20010723122535.3cbd53ef.david@phobia.ms>
	<3804.995906468@axl.seasidesoftware.co.za>
X-Mailer: Sylpheed version 0.5.1 (GTK+ 1.2.10; i386-unknown-freebsd5.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Mon, 23 Jul 2001 18:41:08 +0200
Sheldon Hearn <sheldonh@starjuice.net> wrote:

> 
> 
> On Mon, 23 Jul 2001 12:25:35 -0400, David Hill wrote:
> 
> > NOTE:
> > pcvt -
> > header.h patch now contains #include <unistd.h>
> 
> Wrong approach.  Private (or local, or build-only) headers shouldn't be
> used to include all the crap that the source files that include them
> require.  They should only include headers that are required for the
> things that they themselves declare and define.
> 
> As an example/ pcvt's header.h includes <sgtty.h> so that the type
> "struct sgttyb" is available for the delcaration of sgttyOrg and
> sgttyNew.
> 
> You should include <unistd.h> from the file that needs it; in this case,
> it's main.c .
> 
> > window
> > #include <unistd.h> is in ww.h patch
> 
> Probably the same problem here.
> 
> Ciao,
> Sheldon.

Ok, I fixed those
http://www.phobia.ms/patches/diffs.tar.gz

- David Hill

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message