From owner-svn-src-head@freebsd.org Wed Feb 5 05:00:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E70D12401E7; Wed, 5 Feb 2020 05:00:46 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48C8XG5vF3z45dJ; Wed, 5 Feb 2020 05:00:46 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id AC084F003; Wed, 5 Feb 2020 05:00:46 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [10.10.132.6] (unknown [IPv6:2603:3024:1548:3800:fd22:4b29:424a:6f13]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id E31CFECEA; Wed, 5 Feb 2020 06:00:43 +0100 (CET) From: "Kristof Provost" To: "Gleb Smirnoff" Cc: "Ilja Van Sprundel" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357233 - head/sys/net Date: Tue, 04 Feb 2020 21:00:41 -0800 X-Mailer: MailMate (1.13.1r5671) Message-ID: <3B2A3254-35A4-41BF-A33A-4BD2C4610E71@FreeBSD.org> In-Reply-To: <20200204193239.GR1268@FreeBSD.org> References: <202001282244.00SMiPrb077446@repo.freebsd.org> <20200130163455.GH1268@FreeBSD.org> <3F7A5204-4437-4845-8E40-0BC5D1CD0A5B@FreeBSD.org> <20200204193239.GR1268@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2020 05:00:47 -0000 On 4 Feb 2020, at 11:32, Gleb Smirnoff wrote: > On Sat, Feb 01, 2020 at 07:26:48PM +0000, Kristof Provost wrote: > K> > K> -/* The below interface used only by epair(4). */ > K> > K> +/* The below interfaces are used only by epair(4). */ > K> > K> +void if_clone_addif(struct if_clone *, struct ifnet *); > K> > K> int if_clone_destroyif(struct if_clone *, struct ifnet *); > K> > > K> > IMHO, makes sense to move all these declaration into if_epair.c > K> > itself. > K> > > K> Yeah, that does make sense. > K> > K> One minor issue is that it turns out that if_clone_destroyif() > isn’t > K> just used by if_epair, but also by the wifi code. > K> > K> How does this look? > > Yes, that's what I suggested. However, now given that net80211 also > uses one of these methods, I'm not sure if isolating is a right move. > > In general, we consider if_clone KPI an internal one, don't we? I > mean we don't expect 3rd party device drivers to use it. So may be > it is fine that if_clone.h exposes those functions? It’s been this way for a long time, so .. yeah, I’m inclined to just leave it this way. Arguably we should change the if_clone API to be able to cope with the requirements of if_epair and net80211 as well, but that’s a far bigger project, if there’s even a sensible way to do so. Regards, Kristof