From owner-freebsd-ports@FreeBSD.ORG Mon Sep 17 16:58:27 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AF350106564A; Mon, 17 Sep 2012 16:58:27 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (mail.vx.sk [IPv6:2a01:4f8:150:6101::4]) by mx1.freebsd.org (Postfix) with ESMTP id 411A48FC0A; Mon, 17 Sep 2012 16:58:27 +0000 (UTC) Received: from core.vx.sk (localhost [127.0.0.2]) by mail.vx.sk (Postfix) with ESMTP id 62F6B46989; Mon, 17 Sep 2012 18:58:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk by core.vx.sk (amavisd-new, unix socket) with LMTP id FIQDCyBYW4Mn; Mon, 17 Sep 2012 18:58:21 +0200 (CEST) Received: from [10.9.8.1] (188-167-78-15.dynamic.chello.sk [188.167.78.15]) by mail.vx.sk (Postfix) with ESMTPSA id EB92546969; Mon, 17 Sep 2012 18:58:20 +0200 (CEST) Message-ID: <505756AD.9010806@FreeBSD.org> Date: Mon, 17 Sep 2012 18:58:21 +0200 From: Martin Matuska User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Baptiste Daroussin References: <201209171012.q8HACZZY029228@mech-cluster241.men.bris.ac.uk> <20120917152520.GE13414@ithaqua.etoilebsd.net> In-Reply-To: <20120917152520.GE13414@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anton Shterenlikht , freebsd-ports@FreeBSD.org Subject: Re: [patch] --disable-jit for ia64 in devel/pcre X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2012 16:58:27 -0000 Actually, I see no reason for having JIT in options at all, as it only provides additional functions, there is no signifficant difference in size and the port license doesn't change. I have simply enabled it anywhere besides sparc64 and ia64. On 17.9.2012 17:25, Baptiste Daroussin wrote: > On Mon, Sep 17, 2012 at 11:12:35AM +0100, Anton Shterenlikht wrote: >> devel/pcre fails on ia64 portscluster because defaults >> include JIT: >> >> http://pointyhat.freebsd.org/errorlogs/ia64-errorlogs/e.9.20120916093935/pcre-8.31.log >> >> This patch fixes it. I checked >> it on my own ia64 boxes: >> >> Index: Makefile >> =================================================================== >> --- Makefile (revision 304384) >> +++ Makefile (working copy) >> @@ -32,7 +32,7 @@ >> >> .include >> >> -.if ${PORT_OPTIONS:MJIT} && ${ARCH} != "sparc64" >> +.if ${PORT_OPTIONS:MJIT} && ${ARCH} != "sparc64" && ${ARCH} != "ia64" >> CONFIGURE_ARGS+= --enable-jit >> .else >> CONFIGURE_ARGS+= --disable-jit >> > > OPTIONS_EXCLUDE_ia64= JIT > OTPIONS_EXCLUDE_sparc64= JIT > > Would be cleaner imho > >> This patch is helpful because >> pcre failure on ia64 portscluster blocks an >> estimated 5658 other ports, so would >> be good to get it committed. >> >> HOwever, I wonder if it's better to >> check for $ARCH="i386" && $ARCH="amd64", >> now that we have ppc and arm in portscluster. >> I guess there's no JIT support for those >> arches either. > In that case: > OPTIONS_DEFINE_i386= JIT > OPTIONS_DEFINE_amd64= JIT > > regards, > Bapt -- Martin Matuska FreeBSD committer http://blog.vx.sk Actually, I see no reason for having JIT in options at all, as it only provides additional functions, there is no signifficant difference in size and the port license doesn't change. I have simply enabled it anywhere besides sparc64 and ia64. On 17.9.2012 17:25, Baptiste Daroussin wrote: -- Martin Matuska FreeBSD committer http://blog.vx.sk Enigmail