Date: Mon, 17 Sep 2012 18:58:21 +0200 From: Martin Matuska <mm@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Anton Shterenlikht <mexas@bristol.ac.uk>, freebsd-ports@FreeBSD.org Subject: Re: [patch] --disable-jit for ia64 in devel/pcre Message-ID: <505756AD.9010806@FreeBSD.org> In-Reply-To: <20120917152520.GE13414@ithaqua.etoilebsd.net> References: <201209171012.q8HACZZY029228@mech-cluster241.men.bris.ac.uk> <20120917152520.GE13414@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Actually, I see no reason for having JIT in options at all, as it only provides additional functions, there is no signifficant difference in size and the port license doesn't change. I have simply enabled it anywhere besides sparc64 and ia64. On 17.9.2012 17:25, Baptiste Daroussin wrote: > On Mon, Sep 17, 2012 at 11:12:35AM +0100, Anton Shterenlikht wrote: >> devel/pcre fails on ia64 portscluster because defaults >> include JIT: >> >> http://pointyhat.freebsd.org/errorlogs/ia64-errorlogs/e.9.20120916093935/pcre-8.31.log >> >> This patch fixes it. I checked >> it on my own ia64 boxes: >> >> Index: Makefile >> =================================================================== >> --- Makefile (revision 304384) >> +++ Makefile (working copy) >> @@ -32,7 +32,7 @@ >> >> .include <bsd.port.options.mk> >> >> -.if ${PORT_OPTIONS:MJIT} && ${ARCH} != "sparc64" >> +.if ${PORT_OPTIONS:MJIT} && ${ARCH} != "sparc64" && ${ARCH} != "ia64" >> CONFIGURE_ARGS+= --enable-jit >> .else >> CONFIGURE_ARGS+= --disable-jit >> > > OPTIONS_EXCLUDE_ia64= JIT > OTPIONS_EXCLUDE_sparc64= JIT > > Would be cleaner imho > >> This patch is helpful because >> pcre failure on ia64 portscluster blocks an >> estimated 5658 other ports, so would >> be good to get it committed. >> >> HOwever, I wonder if it's better to >> check for $ARCH="i386" && $ARCH="amd64", >> now that we have ppc and arm in portscluster. >> I guess there's no JIT support for those >> arches either. > In that case: > OPTIONS_DEFINE_i386= JIT > OPTIONS_DEFINE_amd64= JIT > > regards, > Bapt -- Martin Matuska FreeBSD committer http://blog.vx.sk Actually, I see no reason for having JIT in options at all, as it only provides additional functions, there is no signifficant difference in size and the port license doesn't change. I have simply enabled it anywhere besides sparc64 and ia64. On 17.9.2012 17:25, Baptiste Daroussin wrote: -- Martin Matuska FreeBSD committer http://blog.vx.sk Enigmail
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?505756AD.9010806>