From owner-cvs-ports Mon Nov 11 20:34:51 1996 Return-Path: owner-cvs-ports Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id UAA18370 for cvs-ports-outgoing; Mon, 11 Nov 1996 20:34:51 -0800 (PST) Received: from dfw-ix10.ix.netcom.com (dfw-ix10.ix.netcom.com [206.214.98.10]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id UAA18311; Mon, 11 Nov 1996 20:34:46 -0800 (PST) Received: from silvia.HIP.Berkeley.EDU (wck-ca13-06.ix.netcom.com [204.31.231.198]) by dfw-ix10.ix.netcom.com (8.6.13/8.6.12) with ESMTP id UAA10260; Mon, 11 Nov 1996 20:34:08 -0800 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.8.2/8.6.9) id UAA09559; Mon, 11 Nov 1996 20:34:06 -0800 (PST) Date: Mon, 11 Nov 1996 20:34:06 -0800 (PST) Message-Id: <199611120434.UAA09559@silvia.HIP.Berkeley.EDU> To: ache@freefall.freebsd.org CC: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-ports@freefall.freebsd.org In-reply-to: <199611112309.PAA18310@freefall.freebsd.org> (ache@freefall.freebsd.org) Subject: Re: cvs commit: ports/news/tin Makefile ports/news/tin/files md5 ports/news/tin/patches patch-aa From: asami@freebsd.org (Satoshi Asami) Sender: owner-cvs-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk * Modified: news/tin Makefile Thanks. By the way, these lines: === DISTNAME= tin1.3-unoff-BETA-961109 PKGNAME= tin-1.3.${DISTNAME:S/tin1.3-unoff-BETA-//} === Do you mind if I replace the second line with a regular variable assignment to PKGNAME? This is causing me a lot of headaches when you do an upgrade, because I need to delete the old package and its name is not available anywhere in the above for cut & paste. ;) In general, I think munging with :S and stuff for simple variables like PKGNAME is not a good idea. The only times I use this is when the two variables are very far apart in the Makefile (and so the second is more likely to be forgotten when I do an upgrade) or when there are many things to replace. Satoshi