Date: Sun, 13 Apr 2003 13:00:04 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb+freebsdports@zabbadoz.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mchopra@engmail.uwaterloo.ca Subject: ports/50898: abcde netbsd patch merge and cddb proto addition Message-ID: <20030413130004.924A31536C@mail.int.zabbadoz.net> Resent-Message-ID: <200304131310.h3DDA8Sl090885@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 50898 >Category: ports >Synopsis: abcde netbsd patch merge and cddb proto addition >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sun Apr 13 06:10:07 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Bjoern A. Zeeb >Release: FreeBSD 4.7-STABLE i386 >Organization: Zabbadoz.NeT >Environment: System: FreeBSD e0-0.zab2.int.zabbadoz.net 4.7-STABLE FreeBSD 4.7-STABLE #0: Fri Dec 27 22:08:07 UTC 2002 bz@e0-0.zab2.int.zabbadoz.net:/export/src/src/obj/export/src/src/RELENG_4/src/sys/ZAB2-2002122701 i386 >Description: NetBSD has some more abcde patches that p.ex. include audio/normalize support. cddb-tool has hard coded proto=3 which is no good as p.ex. with proto=5 one also gets DGENRE and DYEAR which may be usefull for tagging audio files. >How-To-Repeat: >Fix: I placed a diff (which is more or less a "quick-diff" as I didn't verify everything) on http://sources.zabbadoz.net/freebsd/ports/abcde-20030412-01.diff - patch-b? should be more or less netbsd patches merged and partly modified. One may check if normalizing is on by default even if dependency not selected. I didn't do this. - patch-d? should be my patches for dynamic cddb proto version (5..3) detection. There already had been code in abcde parsing proto 4 return codes from cddb server (proto 4: cddb query -> 210). This patch will break cddb-tool usage if not called from abcde as I needed to change parameters for dynamic proto version adaption from outside. It also adds YEAR and GENRE tagging to vorbiscomment. Perhaps one also wants to add this for other tagging programs. - docu update for patch-d? is missing. Did not read what netbsd did update in their patches. Please review before blindly applying ;-) If you consinder them usefull perhaps send them upstream to abcde author coordination with netbsd people. Thanks. >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030413130004.924A31536C>