From owner-freebsd-dtrace@FreeBSD.ORG  Sat Nov  2 10:21:32 2013
Return-Path: <owner-freebsd-dtrace@FreeBSD.ORG>
Delivered-To: dtrace@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id EAA2BEFD;
 Sat,  2 Nov 2013 10:21:32 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 152EF2CF8;
 Sat,  2 Nov 2013 10:21:31 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA21075;
 Sat, 02 Nov 2013 12:19:20 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1VcYIa-000NiU-0z; Sat, 02 Nov 2013 12:19:20 +0200
Message-ID: <5274D170.6050505@FreeBSD.org>
Date: Sat, 02 Nov 2013 12:18:24 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Mark Johnston <markj@FreeBSD.org>
Subject: Re: "unstable" sdt probes
References: <5268F461.7080504@FreeBSD.org> <20131024161620.GA1710@charmander>
 <526A9CB5.2050207@FreeBSD.org> <20131026180643.GA98676@raichu>
 <527026B3.2070309@FreeBSD.org> <20131031035523.GD9355@raichu>
 <52720017.3060809@FreeBSD.org> <20131102041240.GA23329@raichu>
In-Reply-To: <20131102041240.GA23329@raichu>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: dtrace@FreeBSD.org
X-BeenThere: freebsd-dtrace@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "A discussion list for developers working on DTrace in FreeBSD."
 <freebsd-dtrace.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-dtrace>, 
 <mailto:freebsd-dtrace-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-dtrace>
List-Post: <mailto:freebsd-dtrace@freebsd.org>
List-Help: <mailto:freebsd-dtrace-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace>,
 <mailto:freebsd-dtrace-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2013 10:21:33 -0000

on 02/11/2013 06:12 Mark Johnston said the following:
> Sure, there are multiple probe sites for the sdt:::arc-miss probe, for
> example. For the ip provider, there are multiple probe sites for
> ip:::receive: at least one for IPv4, and at least one for IPv6.

Okay, I think that the following lines in sdt_create_probe should handle this:
        if (dtrace_probe_lookup(prov->id, mod, func, name) != DTRACE_IDNONE)
                return;

It's, of course, a little bit wasteful to have a few duplicate sdt_probe and
sdt_argtype structs, but should not be too terrible.

I wonder if there is some low level trick to collapse this duplicates into a
single object during linking.  Probably not...

-- 
Andriy Gapon