From owner-freebsd-doc@FreeBSD.ORG Tue Nov 25 15:02:24 2008 Return-Path: Delivered-To: doc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 26861106564A; Tue, 25 Nov 2008 15:02:24 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from pittgoth.com (pittgoth.com [205.134.163.206]) by mx1.freebsd.org (Postfix) with ESMTP id C2EB98FC0C; Tue, 25 Nov 2008 15:02:23 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from localhost.fbsdsecure.org (c-68-83-213-214.hsd1.va.comcast.net [68.83.213.214]) (authenticated bits=0) by pittgoth.com (8.14.2/8.14.2) with ESMTP id mAPF23BC024852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 25 Nov 2008 10:02:04 -0500 (EST) (envelope-from trhodes@FreeBSD.org) Date: Tue, 25 Nov 2008 10:01:59 -0500 From: Tom Rhodes To: Manolis Kiagias Message-Id: <20081125100159.6229cffa.trhodes@FreeBSD.org> In-Reply-To: <492C011D.4040707@gmail.com> References: <20081124153358.7a539e67.trhodes@FreeBSD.org> <492B2D8C.4090807@gmail.com> <20081125.102512.193370295.hrs@allbsd.org> <492B7E8E.4070508@gmail.com> <873ahggs02.fsf@kobe.laptop> <492C011D.4040707@gmail.com> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: trhodes@FreeBSD.org, doc@FreeBSD.org, pgj@FreeBSD.org, gabor@kovesdan.org, hrs@FreeBSD.org, keramida@FreeBSD.org, remko@FreeBSD.org Subject: Re: A patch for the 'geom' chapter X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 15:02:24 -0000 On Tue, 25 Nov 2008 15:43:57 +0200 Manolis Kiagias wrote: > Giorgos Keramidas wrote: > > On Tue, 25 Nov 2008 06:26:54 +0200, Manolis Kiagias wrote: > > > >> Hiroki Sato wrote: > >> > >>> Manolis Kiagias wrote > >>> in <492B2D8C.4090807@gmail.com>: > >>> > >>> so> After our discussion, here again is the "second take" of this patch: > >>> so> > >>> so> http://people.freebsd.org/~manolis/geom.txt > >>> > >>> One thing: > >>> > >>> + Permanent labels can be created with the tunefs > >>> + or newfs commands. They will then be created > >>> > >>> I think the &man.tunefs.8; and &man.newfs.8; are better than > >>> foo here. > >>> > >> True, will change these. > >> > > > > I just finished reading the new patch. Excellent work :) > > > > Thanks :) > > Just a minor point that may make the gjournal parts friendlier to mirror > > admins. You don't have to hardcode `www.freebsd.org' or the path to the > > gjournal article into the Handbook. > > > > This part: > > > > + Please refer to the article > + url="http://www.freebsd.org/doc/en_US.ISO8859-1/articles/gjournal-desktop">Implementing UFS Journaling on a Desktop PC > > + for detailed instructions on this task. > > > > Can be written as: > > > > + Please refer to the article > + url="&url.articles.gjournal-desktop;">Implementing UFS Journaling on > > + a Desktop PC for detailed instructions on this task. > > > > I have updated `doc/share/sgml/urls.ent' to include URL entities for our > > current set of articles, including gjournal-desktop, so if you update > > from CVS the patch should build fine either way. > > > > Patch approved by me too. > > > > > > > I knew there would be another way for this long link. Thanks, I'll > change it and will probably commit later today. > > Many thanks to anyone who took the time to review this! This has my rubber stamp too - I think all my issues have been pointed out and fixed. Thanks! -- Tom Rhodes