From owner-freebsd-current@FreeBSD.ORG Mon May 12 01:50:42 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2C99C6C3; Mon, 12 May 2014 01:50:42 +0000 (UTC) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com [IPv6:2a00:1450:4010:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B3E92A52; Mon, 12 May 2014 01:50:41 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id ec20so1379876lab.40 for ; Sun, 11 May 2014 18:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=vQHfs/6H2KcD5FBbIQZqyPv83lHzeeGvbADrVt7VIiM=; b=Rsagg+dqytwMs+RDHoa2jhrV2ne9YNJkVy296BkMFpaHgewybe9tsqkINO6uFL6UXh Pa+1++RjxpXjiXGIJV7tLWj0zdqz+J9JzcE0GOGBWsLoRdDX7qDXC1qRHvjlm8havMG5 KQaVc2EVhRcxqhznX12b/k0HgImwcTFIasRNHrjwv2/rFbruq739CZG78/GSXvUoXsTC ozxUTSvYe97Nu9IsUo17xbuKFQhU33DRihcSTsJcHp9LgXBbv22VZKmJHc+Lri1WLXhy kbb2wGakT5+hDkju2pGE5BWu10oBhW6SoKb/AP8XXFwjfqpt9z67bo9YS1BWMkvD7kTd u4pA== MIME-Version: 1.0 X-Received: by 10.112.149.71 with SMTP id ty7mr4311191lbb.34.1399859439456; Sun, 11 May 2014 18:50:39 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.67.73 with HTTP; Sun, 11 May 2014 18:50:39 -0700 (PDT) In-Reply-To: <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <130417FC-CE39-43DE-B87F-DF2185FC94DC@bsdimp.com> <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com> Date: Sun, 11 May 2014 18:50:39 -0700 X-Google-Sender-Auth: Eq8-SPgWWOWPpv8xyzC-DKlWpIE Message-ID: Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 From: Craig Rodrigues To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current Current , "jenkins-admin@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2014 01:50:42 -0000 On Sun, May 11, 2014 at 4:22 PM, Warner Losh wrote: > > > The only logic that can work is to test MAKESYSPATH and respect it if it = is defined, and use the relative path if not (since we don't require MAKESY= SPATH to be defined to do a out-of-tree module build, and could be built on= a system that isn't running the latest current). That is a legitimate patch. I've seen people make similar changes to the kernel makefiles an mk rules, specifically folks who import FreeBSD kernel source into their tree, but have the mk rules in a "non-standard" place. Thanks for applying this change. > > > Using JIRA to force it is rather an annoying use of JIRA since it makes = making JIRA happy hard to test and outside the normal work flow. Please use the correct terminology to avoid confusion. Jenkins is not the same as JIRA. -- Craig