From owner-p4-projects@FreeBSD.ORG Thu Dec 4 00:33:41 2014 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 70724D88; Thu, 4 Dec 2014 00:33:41 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 316C8D86 for ; Thu, 4 Dec 2014 00:33:41 +0000 (UTC) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:1900:2254:2068::682:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1DEAC7C6 for ; Thu, 4 Dec 2014 00:33:41 +0000 (UTC) Received: from skunkworks.freebsd.org ([127.0.1.74]) by skunkworks.freebsd.org (8.14.9/8.14.9) with ESMTP id sB40Xewp063219 for ; Thu, 4 Dec 2014 00:33:40 GMT (envelope-from jmg@freebsd.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.9/8.14.9/Submit) id sB40Xe0n063216 for perforce@freebsd.org; Thu, 4 Dec 2014 00:33:40 GMT (envelope-from jmg@freebsd.org) Date: Thu, 4 Dec 2014 00:33:40 GMT Message-Id: <201412040033.sB40Xe0n063216@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to jmg@freebsd.org using -f From: John-Mark Gurney Subject: PERFORCE change 1203490 for review To: Perforce Change Reviews Precedence: bulk X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.18-1 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 00:33:41 -0000 http://p4web.freebsd.org/@@1203490?ac=10 Change 1203490 by jmg@jmg_carbon2 on 2014/12/04 00:33:16 forgot in previous commit.. it could have been written more simply, but clang and gcc really want a constant for the index in _mm_insert_XXX, if not, you might get some other strange code... Even though something like: _mm_insert_XXX(a, b, !!ndx) would result in exactly the same range of args and everything, clang will compile, but to code not using pinsrd... In our case, we didn't have this problem, but incase someone pulls my code for some reason, they'll get reasonable code... Affected files ... .. //depot/projects/opencrypto/sys/crypto/aesni/aesni_ghash.c#7 edit Differences ... ==== //depot/projects/opencrypto/sys/crypto/aesni/aesni_ghash.c#7 (text+ko) ====