From owner-freebsd-current@FreeBSD.ORG  Thu Jun 11 13:34:38 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 28C76106566C
	for <current@freebsd.org>; Thu, 11 Jun 2009 13:34:38 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129])
	by mx1.freebsd.org (Postfix) with ESMTP id DFF498FC14
	for <current@freebsd.org>; Thu, 11 Jun 2009 13:34:37 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id 269FB730A1; Thu, 11 Jun 2009 15:39:57 +0200 (CEST)
Date: Thu, 11 Jun 2009 15:39:57 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Attilio Rao <attilio@freebsd.org>
Message-ID: <20090611133957.GA23404@onelab2.iet.unipi.it>
References: <20090611130800.GA22241@onelab2.iet.unipi.it>
	<3bbf2fe10906110628l24d538ccu6ef9c5af354638ab@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3bbf2fe10906110628l24d538ccu6ef9c5af354638ab@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: current@freebsd.org
Subject: Re: proposed bio.h change
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jun 2009 13:34:38 -0000

On Thu, Jun 11, 2009 at 03:28:32PM +0200, Attilio Rao wrote:
> 2009/6/11 Luigi Rizzo <rizzo@iet.unipi.it>:
> > I noticed that sys/sys/bio.h unnecessarily exposes various
> > structures to userland.
> > If there are no objections I would like to commit the
> > following change (moving the bio_cmd values up because
> > they are used by ggatectl)
> 
> I think you should export CMD too for this interface.

I am not sure what you are referring to with 'CMD'.

The only strings matching 'CMD' are the bio_cmd #defines,
which as i said are exported, and the uint8_t bio_cmd
field in struct bio, which is passed up by the ioctl()
as a field of a separate struct, which contains only a
subset of struct bio fields.

Anything else I don't see ?

cheers
luigi