From owner-cvs-src@FreeBSD.ORG Sat Mar 8 18:37:03 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA0CF106566B; Sat, 8 Mar 2008 18:37:03 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A063F8FC1B; Sat, 8 Mar 2008 18:37:03 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m28Ib3uA036415; Sat, 8 Mar 2008 18:37:03 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m28Ib3C3036414; Sat, 8 Mar 2008 18:37:03 GMT (envelope-from bz) Message-Id: <200803081837.m28Ib3C3036414@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 8 Mar 2008 18:37:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netipsec key.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 18:37:03 -0000 bz 2008-03-08 18:37:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netipsec key.c Log: MFC rev. 1.26 key.c In case of failure we can directly return ENOBUFS because 'result' is still NULL and we do not need to free anything. That allows us to gc the entire goto parts and a now unused variable. Found with: Coverity Prevent(tm) CID: 2519 Revision Changes Path 1.20.2.4 +3 -10 src/sys/netipsec/key.c