From owner-cvs-all  Thu Jul 19  9: 8:39 2001
Delivered-To: cvs-all@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP
	id 729E437B405; Thu, 19 Jul 2001 09:08:34 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.2) id f6JGP8j55551;
	Thu, 19 Jul 2001 12:25:09 -0400 (EDT)
	(envelope-from mike)
Date: Thu, 19 Jul 2001 12:25:08 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Dima Dorfman <dima@unixfreak.org>
Cc: mi@aldan.algebra.com, kris@FreeBSD.org,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/mailwrapper mailwrapper.c
Message-ID: <20010719122508.B55442@coffee.q9media.com>
References: <200107191440.f6JEedO32662@aldan.algebra.com> <20010719144945.0B1AA3E2F@bazooka.unixfreak.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010719144945.0B1AA3E2F@bazooka.unixfreak.org>; from dima@unixfreak.org on Thu, Jul 19, 2001 at 07:49:45AM -0700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, Jul 19, 2001 at 07:49:45AM -0700, Dima Dorfman wrote:
> Mikhail Teterin <mi@aldan.algebra.com> writes:
> > On 18 Jul, Kris Kennaway wrote:
> > > kris        2001/07/18 22:04:46 PDT
> > > 
> > >   Modified files:        (Branch: RELENG_4)
> > >     usr.sbin/mailwrapper mailwrapper.c 
> > >   Log:
> > >   MFC: r1.6:  You can't  free a string  and then use  it as  the error
> > >   message to errx. Instead use warn  to print the string, then cleanup
> > >   and exit normally.
> > 
> > This is  not the first  place to have this  issue (I remember  a similar
> > commit from the past). May be, it  is time to add another err* function,
> > which will free the passed error message prior to exiting?
> > 
> > It was not there before, I guess, because the "founding fathers" did not
> > concern themselves with the fate of the allocated memory after exit :-)
> 
> Maybe I'm missing something, but who cares about allocated memory
> *after* *exit*?

Good programmers?  :)

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message