From owner-cvs-src@FreeBSD.ORG Thu Jun 24 18:55:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D60A416A4CE for ; Thu, 24 Jun 2004 18:55:13 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id A16A943D5E for ; Thu, 24 Jun 2004 18:55:13 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 31850 invoked from network); 24 Jun 2004 18:54:34 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 24 Jun 2004 18:54:33 -0000 Received: from 10.50.41.233 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i5OIsLeP073738; Thu, 24 Jun 2004 14:54:22 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Josef El-Rayes Date: Thu, 24 Jun 2004 14:55:24 -0400 User-Agent: KMail/1.6 References: <200406241741.i5OHfKjn052472@repoman.freebsd.org> <200406241408.08014.jhb@FreeBSD.org> <20040624181801.GD583@jenny.daemon.li> In-Reply-To: <20040624181801.GD583@jenny.daemon.li> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406241455.24148.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pcm mixer.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2004 18:55:14 -0000 On Thursday 24 June 2004 02:18 pm, Josef El-Rayes wrote: > John Baldwin wrote: > > Does this really need to be here considering that with rcNG (on by > > default on current) and /etc/rc.d/mixer this has no effect? > > Eugene Grosbein requested this (kern/63771) implicitely > and Cameron Grant decided that it is good to accomplish > this via kenv variables. > > It literally adds only ~5 lines of code, it does not > decrease stability but adds a feature, I see > lots of kernel modules configurated via hints and > bootloader, why not let pcm be configured via this too. > Why do we have to force users to use mixer script, which > is not documented anywhere too. > > I will, of course, remove it, if it is wished, I just > dont see why anyone would have a problem. It's more that in its current form it doesn't do anything. :) If you had run this code on a current box with rcNG you would have found that out before committing so that a solution could be worked out. As it is now, you could already achieve the desired functionality by simply muting the channel while the box was in multiuser and the channel would stay muted across reboots until you explicitly unmute it. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org