From nobody Wed Apr 22 23:49:56 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1GDd1kMnz6b5m8 for ; Wed, 22 Apr 2026 23:50:09 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1GDd197lz3fc9 for ; Wed, 22 Apr 2026 23:50:09 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2b2ea1b3962so35272695ad.0 for ; Wed, 22 Apr 2026 16:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776901808; x=1777506608; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pZggVrtbwBU56nmqAFK8o3L4iujVW0y6vFRlClEhWRc=; b=hNSdik0dinjrPuwGPYkZbuLAhnzpjeHwHiE/4Zrv0sIlzvR2EPE5HpikRVIaKf9nF2 Ankq2uzC0FDXRPPhxhwqgJD/FOxbzXAk1kNBa6gOnqryG8dDy+RAQUneVrph2IxANcpK /AKut0ALys+QhiESMT7X4Vveebc2p13PpaEp7wuNxEYctOYPPpf7iSWwNohIqsy8IpJZ SXuAF6GyEjPYzp93JQEifFStlIdj1RhkBj8wzwx6m8KvQ3KrVdhLSDAwCsOZErWTB9vF 30yoNBvzvNQr7qG3MSgdkvFrWoXfkcrS7EwSvOa4GezYf6R079FrH9fMZHRJ8W8Bx0WA qrfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776901808; x=1777506608; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pZggVrtbwBU56nmqAFK8o3L4iujVW0y6vFRlClEhWRc=; b=segyK6OGQMpa9aXUgAVc79Y+cW7+Ow/FH367HN84ZtcfA/32X3TRMd8LgZsWasaxKN u60gyzcFgMp8LvIuIXwBiO47MKb4jCMOou0z/iO15NFRg69UwZ634gGOHh4lkx1yUxw5 QdHVQgQoiOS2Blpl6sWeVWsEPAGB1XWBHrlYJSYBJQMAJehe3Yb1XMYYYwFwwCeeeJ4c mppK0qdlPtz8TVv6gg00unPlEtYUOrkKhLNfN7oV7uKoiAa183sOxpNw/d0l1ZHZ59cQ 4smn5a76UQQs6zLNnbps281j/T3eEXE0ZEuzpI0cWfneDobmdW3F0wxZqixvE5EVpftp ouYQ== X-Forwarded-Encrypted: i=1; AFNElJ/H/C0ad85o5rlD3HkT90ddSCAJ/VkWgU5ftiZMoNwI6bQIegyW0wSbI+0Z2rb03xdfGPlWYv1rtf0UVB/eW3ETcurc5A==@freebsd.org X-Gm-Message-State: AOJu0YxKp2ipnasqDDiPdMbOLoWaeLmDA9hX3c9grDJZslAQCdtWu/G7 SU9PuUGsSGrcAn8+JDJPIt7OU8IrdQ5/l1LheAVx1pjL3qg5y/kxBIL4 X-Gm-Gg: AeBDievcjqWR0FdGYNalrcH5oeDbX2nM0BXnAcOQ/55HrANYNYN5hq8vEIjjFBS7oTf 3x5j53DJhl85kJ9D+bnuWEPrPcYXm3MXt+y2eYqZBGoQnE12Li9BPkUyFmnhAXQTxtJzWg7ZC5d bA4rplSLTam3yJj0WGSsolda0q5+TVFQ9vYPD63xTuUWscrhwt7ijYsGir4y2QIiG9FYBssdCRk M76zlJxKnvMezxBmU/ph74Y7fX2ESaQk8oByPx2+ark/piRnfIk3hWJgCBAhhf/F6OKCMGT9twO McktTFN2teCAr/kKb5mRYoOIRvi9xBwVsl3OJrws8FEf8WsPyW+QmHcZ2yJHJ2Ti9gcN59T75xy yQ3G+Xrd/bRI1tmhshQnUDEEGTQA4mUnV0PQ1uUXWEf+6f9uTrl0I1WiQnAhGH9dVZMC6ilyVcI fCf04TtLAkqgppsrbplVWNESHU7XrDCwQi44CKizzr6jV3CrqIyp0lzbMM X-Received: by 2002:a17:902:e746:b0:2b2:42da:25c4 with SMTP id d9443c01a7336-2b5f9ef6877mr292914005ad.14.1776901808124; Wed, 22 Apr 2026 16:50:08 -0700 (PDT) Received: from smtpclient.apple ([176.100.43.95]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b606ce9891sm137833905ad.83.2026.04.22.16.50.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Apr 2026 16:50:07 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 48d6db4932c8 - main - OpenSSL: move `-DOPENSSL_PIC` from `PIC_FLAG` to `SHARED_CFLAGS` From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Wed, 22 Apr 2026 16:49:56 -0700 Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <69e930dd.253f6.360e2614@gitrepo.freebsd.org> To: Jessica Clarke X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4g1GDd197lz3fc9 X-Spamd-Bar: ---- > On Apr 22, 2026, at 2:24=E2=80=AFPM, Jessica Clarke = wrote: >=20 > On 22 Apr 2026, at 21:34, Enji Cooper wrote: >>=20 >> The branch main has been updated by ngie: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D48d6db4932c8ec04ca3df79119803f8c= 7c1570d7 >>=20 >> commit 48d6db4932c8ec04ca3df79119803f8c7c1570d7 >> Author: Enji Cooper >> AuthorDate: 2026-04-21 23:46:19 +0000 >> Commit: Enji Cooper >> CommitDate: 2026-04-22 20:34:25 +0000 >>=20 >> OpenSSL: move `-DOPENSSL_PIC` from `PIC_FLAG` to `SHARED_CFLAGS` >>=20 >> `PIC_FLAG` should be used strictly for `-fPIC`, `-fpic`, etc, = options. >> `SHARED_CFLAGS` is the more appropriate place to this flag to be = set. >>=20 >> Requested by: jrtc27 >=20 > Thank you! >=20 >> MFC after: 3 days >> MFC with: 3797fe720a >> --- >> secure/lib/libcrypto/Makefile.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/secure/lib/libcrypto/Makefile.inc = b/secure/lib/libcrypto/Makefile.inc >> index 8f22d501e005..85e2c0813b79 100644 >> --- a/secure/lib/libcrypto/Makefile.inc >> +++ b/secure/lib/libcrypto/Makefile.inc >> @@ -13,7 +13,7 @@ CFLAGS+=3D -I${LCRYPTO_SRC}/providers/fips/include >> CFLAGS+=3D -I${LCRYPTO_SRC}/providers/implementations/include >>=20 >> PICFLAG=3D -fPIC >=20 > Assuming nothing else is messing with it, this can now go? That=E2=80=99s a good question. I=E2=80=99ll try taking it out and see = what happens. -Enji PS This is what the code used to look like prior to my other change =E2=80= =94 I moved the definitions from secure/lib/libcrypto/Makefile to = secure/lib/libcrypto/Makefile.inc so the symbols could be incorporated = into all of the OpenSSL-related libraries (including the legacy = provider, libssl, etc): ``` diff --git a/secure/lib/libcrypto/Makefile = b/secure/lib/libcrypto/Makefile index 738de3479987..9d484e9d480c 100644 --- a/secure/lib/libcrypto/Makefile +++ b/secure/lib/libcrypto/Makefile @@ -687,12 +687,6 @@ SUBDIR.${MK_TESTS}=3D tests .include -.if ${MACHINE} =3D=3D "powerpc" -# Work around "relocation R_PPC_GOT16 out of range" errors -PICFLAG=3D -fPIC -.endif -PICFLAG+=3D -DOPENSSL_PIC - .if defined(ASM_${MACHINE_CPUARCH}) .PATH: ${SRCTOP}/sys/crypto/openssl/${MACHINE_CPUARCH} .if defined(ASM_amd64) diff --git a/secure/lib/libcrypto/Makefile.inc = b/secure/lib/libcrypto/Makefile.inc index 73c650d590ff..8f22d501e005 100644 --- a/secure/lib/libcrypto/Makefile.inc +++ b/secure/lib/libcrypto/Makefile.inc @@ -12,6 +12,9 @@ CFLAGS+=3D = -I${LCRYPTO_SRC}/providers/common/include CFLAGS+=3D -I${LCRYPTO_SRC}/providers/fips/include CFLAGS+=3D -I${LCRYPTO_SRC}/providers/implementations/include +PICFLAG=3D -fPIC +PICFLAG+=3D -DOPENSSL_PIC + .SUFFIXES: .pc .PATH.pc: ${LCRYPTO_SRC}/exporters ```=