From owner-freebsd-current@FreeBSD.ORG Mon May 12 02:54:58 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95D0C692 for ; Mon, 12 May 2014 02:54:58 +0000 (UTC) Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com [209.85.213.182]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 511DC2EED for ; Mon, 12 May 2014 02:54:57 +0000 (UTC) Received: by mail-ig0-f182.google.com with SMTP id uy17so3285193igb.3 for ; Sun, 11 May 2014 19:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=JphFOGGbMwKYl2fIx1QseCilwSXnnEF/vg+5CH1H3jU=; b=Y7jXXDkP2VbsQFueudjZs+PhXqq2AjuqSuKuhzb5+5lQSsjgqzuFlNkfPdR5ZFLLh+ Buj18Gmjq0r6w0Ohns2SmiL156vjUDfyfrI/9hQOUFWGoZq/sT54+SdP/9ls2PLyVgma c94N7Zv3bIXPyNqpwg8R5j3kxUhuX9W6x2GV0udBdCgOc63p4Kt1eAfGmrfvmrUTbshi Lv3WtlbukckoC6wyrMnPGVM+62vrFN6NPyrNnbayz4YOGFLd0iYZLjAGsShJ9k4m6BQ5 1Wj5Skc4JW+RFL/1p2GNUgEbLZXcWtsYknG3XmaEvPDOc263TfW+S0THvVFloVah5ytV lJFg== X-Gm-Message-State: ALoCoQkHTe7BCeZFjorJcotEbqR7cfSL/GzbDMD/ZW4i/DsyrMarDjT7XU2cmLzzV88Z81nJJOJq X-Received: by 10.50.25.201 with SMTP id e9mr38837339igg.28.1399863296883; Sun, 11 May 2014 19:54:56 -0700 (PDT) Received: from [10.0.0.119] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id ab1sm15152870igd.12.2014.05.11.19.54.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 11 May 2014 19:54:56 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_A77C55B3-1692-4735-99DA-05D73029CA97"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 From: Warner Losh In-Reply-To: Date: Sun, 11 May 2014 20:54:54 -0600 Message-Id: <0066AA01-132B-4042-88FE-DE264667BF81@bsdimp.com> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <130417FC-CE39-43DE-B87F-DF2185FC94DC@bsdimp.com> <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com> To: Craig Rodrigues X-Mailer: Apple Mail (2.1874) Cc: freebsd-current Current , "jenkins-admin@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2014 02:54:58 -0000 --Apple-Mail=_A77C55B3-1692-4735-99DA-05D73029CA97 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 11, 2014, at 7:50 PM, Craig Rodrigues = wrote: > On Sun, May 11, 2014 at 4:22 PM, Warner Losh wrote: >>=20 >>=20 >> The only logic that can work is to test MAKESYSPATH and respect it if = it is defined, and use the relative path if not (since we don't require = MAKESYSPATH to be defined to do a out-of-tree module build, and could be = built on a system that isn't running the latest current). >=20 > That is a legitimate patch. I've seen people make similar changes to > the kernel makefiles an mk rules, > specifically folks who import > FreeBSD kernel source into their tree, but have the mk rules in > a "non-standard" place. > Thanks for applying this change. Sure. Still not sure what I think about it, but it does work and I have = bigger fish to fry... >> Using JIRA to force it is rather an annoying use of JIRA since it = makes making JIRA happy hard to test and outside the normal work flow. >=20 >=20 > Please use the correct terminology to avoid confusion. > Jenkins is not the same as JIRA. Yes. Others have corrected me as well. Sorry for the confusion=85 Warner --Apple-Mail=_A77C55B3-1692-4735-99DA-05D73029CA97 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTcDf+AAoJEGwc0Sh9sBEAmjEP/3CXY17LXmhqa/jf7m/OFmJa kBC0nQxMrvRyxlfSg048h3u1malIVVoboogZT86xEFwOWcPcHuV560WVHt34W5JB lKRvLUHV+Axygv/tVuleeynKeKk6APLxSuCnrmc/+ZA9JB+KzJBKiSduWsHCcuHY kNl24z5FMgPguJsz053c7Tl7Ul1m6gUN4hTVZTJl6AK+DePBu5F35yNB8GsWxZdt rcZG9uD18lS5dNKNJhCDNif2VHLiwVDbtODyiUX4OIAarvKEq4uq8SBT5yPbanjV mhwQeOEAAfC+KhmjY3125ujD/75Y53sjKXAdtdMYoLdW/UXL3rR8T0PkoB4/CfhV Wv4JTyHcq4eT2eyFjfmOY7DLFayjXa8GNhekmw9OmSRfosRcZKXmoKd5wP5/3biu h8dssTf2SVqWmpTws67Bn0LV/LlU3l+W2yJuEyjGHVerpLD1l1FR9ujGmEzX64HY SBJ/GixCEMUcgkBA0or3jzXq28PLzLn6QEnCH+AuVIZ84tSgoYCjCn6amOZTjvAF /IoqpecYyN7FHc3YyLUAaBeVPaw80ec0KtC+toWptip/HmUDVAP0Pa/GkSj4UwV8 GcauFLgJQ+11mgTmn6fwk21D1qvI5g+YcWFQA+j28MQIKrVCanhjT7DQzWSQLXnW gC6uV+SjoxOnLWQcYDoE =MNzl -----END PGP SIGNATURE----- --Apple-Mail=_A77C55B3-1692-4735-99DA-05D73029CA97--