From owner-freebsd-hackers@FreeBSD.ORG Mon Jan 5 14:29:57 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C44FB16A4CE for ; Mon, 5 Jan 2004 14:29:57 -0800 (PST) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 920DF43D31 for ; Mon, 5 Jan 2004 14:29:56 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 9254 invoked from network); 5 Jan 2004 22:29:56 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 5 Jan 2004 22:29:56 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i05MTqM0021579; Mon, 5 Jan 2004 17:29:52 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20040102151458.P10254@root.org> Date: Mon, 05 Jan 2004 17:29:54 -0500 (EST) From: John Baldwin To: Nate Lawson X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: hackers@freebsd.org Subject: Re: Power Patches X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2004 22:29:57 -0000 On 04-Jan-2004 Nate Lawson wrote: > I get a panic on my T23 due to the ATA driver not being detected so no > rootvp. Attached are dmesg both before and after the patch. The cbb0 > issue is a regression since I have specified it to use an unused IO range > via this tunable (the same range Windows uses): > > hw.cbb.start_memory=0xc0203000 > > I commented out that tunable while testing the power kernel. > > One thing you should fix is calling the acpi set methods with a NULL > pointer: > > pci2: Failed to set ACPI power state D3 on (null): AE_BAD_PARAMETER > > You should probably just skip the call to the acpi set power state if it's > null. Well, see, I'm not sure yet what pointer is null. That is the output of acpi_name() on a handle. It would help to know what bus/device/func that is and if your ASL has a correspondnig device in the tree or not. It may be that acpi_handle() is returning NULL and in that case I guess we should just not try to adjust ACPI power resources/_PSx but just stick to the pci powerstate stuff. If you could verify what is actually NULL that could help however. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/