Date: Thu, 27 Jun 2019 18:54:02 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349459 - head/sys/sys Message-ID: <dec79f80-3b00-15ad-cd63-6e6ecb83e176@FreeBSD.org> In-Reply-To: <20190628012059.D2091@besplex.bde.org> References: <201906271507.x5RF775Q070616@repo.freebsd.org> <20190628012059.D2091@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27/06/2019 18:47, Bruce Evans wrote: > On Thu, 27 Jun 2019, Andriy Gapon wrote: > >> Log: >> upgrade the warning printf-s in bus accessors to KASSERT-s >> >> After this change sys/bus.h includes sys/systm.h. > > This is further namespace pollution. sys/systm.h is a prerequiste for > all kernel headers except sys/param.h and the headers that that includes, > since any kernel header (except sys/param.hm etc.) may have inlines which > use features in systm.h, e.g., KASSERT() or an inline function. Bruce, what do you think about amending style(9) to require that if sys/systm.h is to be included, then it must be included before any other header except for sys/param.h (and possibly sys/cdefs.h) ? -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dec79f80-3b00-15ad-cd63-6e6ecb83e176>