From owner-svn-src-head@freebsd.org Thu Dec 31 18:45:03 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB9FEA56EB7; Thu, 31 Dec 2015 18:45:03 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0119.outbound.protection.outlook.com [207.46.100.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 39400180C; Thu, 31 Dec 2015 18:45:02 +0000 (UTC) (envelope-from jtl@freebsd.org) Received: from BY2PR05CA047.namprd05.prod.outlook.com (10.141.250.37) by BY1PR0501MB1381.namprd05.prod.outlook.com (10.160.107.139) with Microsoft SMTP Server (TLS) id 15.1.361.13; Thu, 31 Dec 2015 18:29:20 +0000 Received: from BL2FFO11OLC008.protection.gbl (2a01:111:f400:7c09::168) by BY2PR05CA047.outlook.office365.com (2a01:111:e400:2c5f::37) with Microsoft SMTP Server (TLS) id 15.1.361.13 via Frontend Transport; Thu, 31 Dec 2015 18:29:20 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=freebsd.org; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=freebsd.org; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning freebsd.org discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BL2FFO11OLC008.mail.protection.outlook.com (10.173.160.143) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Thu, 31 Dec 2015 18:29:20 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 31 Dec 2015 10:29:16 -0800 Received: from [172.29.33.31] ([172.29.33.31]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id tBVITCD93990; Thu, 31 Dec 2015 10:29:13 -0800 (PST) (envelope-from jtl@freebsd.org) User-Agent: Microsoft-MacOutlook/14.5.9.151119 Date: Thu, 31 Dec 2015 13:29:12 -0500 Subject: Re: svn commit: r292955 - head/lib/libmd From: "Jonathan T. Looney" Sender: Jonathan Looney To: Bruce Evans CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Thread-Topic: svn commit: r292955 - head/lib/libmd References: <201512301804.tBUI4oGp065466@repo.freebsd.org> <20151231115651.R995@besplex.bde.org> In-Reply-To: <20151231115651.R995@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC008; 1:gGOwnbLeHJ6myRWB98EeJ/7TK3S8wkVOWi2a6sOQifKptR0qskfde/v38xlmP5LuA+FklAVhRGzPXRyywmyq9aI7JbhXAhmOshPOlJ3cuIDHLsj6IkMKSYXJJknmuySE5gXejf4l3k0jlL7/xp9uphN0TDcZtn1Js8QfxPmJzc2pRNiblXOwCJN3HsyMY84dqtSmQH0jL5IjpPztcm/1rdWYhTqcw4qoCVmbtNGhYJh/iyY2ikRjbn742OnVbiii8Ul/2iw+O0tsaNUikn2V5CHzndhTBHlvufuLGOh0kJD1D/Fy5qpf4uBAy+DOucA5X/9HQ+h98lMgUXoCIv8YpiwQTODaY3OJ7eciSQLAMeB92ZA7f1QQxyCA0q+OgdDuRJaWJ+MK+9mW7ohwj8R6pQ== X-Forefront-Antispam-Report: CIP:66.129.239.19; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(377454003)(189002)(24454002)(199003)(479174004)(4001350100001)(47776003)(2950100001)(230700001)(92566002)(97736004)(46406003)(6806005)(50986999)(50466002)(16796002)(4326007)(586003)(54356999)(69596002)(23726003)(81156007)(76176999)(5001960100002)(1220700001)(83506001)(1096002)(11100500001)(36756003)(189998001)(87936001)(105596002)(86362001)(106466001)(77096005)(19580405001)(19580395003)(110136002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0501MB1381; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0501MB1381; 2:8EaYlhfaKUgz5DWjhg54OH3rbwt8JLAJlnq712yKZ4ItjY86HVWhYOxDgVhjJyaEkeRNC3a3DVykoHvSurtb4KiUTUCmzGYO71z8N2TbKK2FgjK9rtMgRirK0sU0GsIdYlbOKwIf+i2ZxxA9TF5sew==; 3:7fT/18wvYl7ibSToH//cKrlobKZv4OqIIKFnI5QfFbRiu4zslMUs4o1RY/fHuIElb8bNVyXVNldUZKxrDaAbSdTD43XovxqeZgtSwSCpu6k564O5tlZW3wApDUYL84i/Kmvp4ft/hC0phPve66kAR126d3exB8TDx5Ql+qm6dJ8VbBRXZDd6XIU0tTf+P1Hb4QIs3FkRJpiJjSo/5kbYQT2CsHTdhQ91wmJOb0ls+j0=; 25:fI0I8Ws7fxxbf4b9ZV5hcUSQyH/M2qoRCz9RgILc25AnYYRBUUVSrzKxxrTJhTUeJAyIiRPV8rsCi5S4ZN5fzUvsZfozacXDIFDLX3ebHrW29QeIQS+Vw79n9MHlQqIclL27DVL2V1wylKHh3fSfzlEHUohQu2agp2XUDlSwFNBbLAIVH58zl/W5iU0clm9iI5tlKpxyoEpxFBSGyggK6ONDTVyI4BeoT23XjopLCyudsvWw5brN2Vo9LWL13Jya6Av2qmHPIyPkcmP/ARdjjg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0501MB1381; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0501MB1381; 20:2M7brepewhJZRi2iTKwaGoThHbiNmd9cN36X7agXt9Sc/TrDO9p7iZDnssWyEXUOa8tNpouZPJrM29uesdTI8R4X7aHpv6/kCyJNqjmg7H42N5qcVm8DPm3NRA/bvv7dWaAXoqONCMrd3WIFHwfIxK/4QGz+92AjdBQmzAQzoPXXhzM02POy99bs+VAb8XGsobuKthiVtl0/356haLeVRmBBFDR59Kw1MXmmx3wD0i1lr9SVrBs6d3aksMivETmsLq4VeN/gcSedQtA97cSwij+eZW/cc19krkVej+Q0V5BZdRUn7GoUg6zjQ+DPWQvw4XGWDrW7vS43SDTHz0m70/69ozY9Kdc9JOXdM5/BeHW8AKNyr1534IfHaReaidsTE+RoK1bdmUmAEsB7tzpdcEGRdcSHmeqCTSMTN4pso3oJnu4ZqfriBwnU+Wl2/tXKbmlEg+3uMhvvUGfuBxTkrEtib3MJXxqxay9MS3zrTIo5oQyQILfd5thbUmEOcDGC; 4:h16YszazFTe0n1loUyfB7nBwPERl6+rG4xLIK7PjKKO+LFjyO+JCs4PXb2fgYqgg1b4Sf6EsZ/abC9dhDzPPtjerwYmjrf7iuN2PuqAdYoxBlm4g24t7m3B/He2P52KoLGdFYNktS8mUQUvj0mSyKxQ0nxeVyiPMgsxxd4A80qPiI2E1Y6/1v7ql+d0r2OLGxG0VW4rRjwXMehAC07McGvEWL8yu4W9Vear8VppXZ7fl9OlEllTDq13BxvlXOwoL+3J5ow6Nv2oqXNZUghKJWjkFMo6KeG+5SBn/CW9qmfkc94qE69v1oAbsIe5TBcQUD6VAFlcmZfKOZWk2NvIJhbydhj+Vn+UcghY3IJLGrgWLdjlJYx8snaeBvCrhi1qJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001); SRVR:BY1PR0501MB1381; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0501MB1381; X-Forefront-PRVS: 08076ABC99 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0501MB1381; 23:YeJKbtVFhv5a+NZK0y2aaZ8ywnw5hbL4G1EXBMg?= =?us-ascii?Q?MoyaBVqV1HGyqD+2VtnHhbfuPXUukI7BmnHNXwr8MKBF0pvpvGpjhSUABNqD?= =?us-ascii?Q?hQ6vkBzA/w6tGgG1MplvIST/wsOxQjdgEcdyH6lUjRxhE0Z1JWoAv+09JDJ5?= =?us-ascii?Q?rhS5vHeTGre2yzOBZRYF9jioTk/l5oGAox+RIkL/ykBbx4BKO6UHfKs8DWaN?= =?us-ascii?Q?QkWxmlqmeETJW30Pzlv/9hapiF+f+lyROjyLFfpw7EePV02w4981gRdneDxK?= =?us-ascii?Q?U8cdjgsYvNOV6sxxvXTbPh04D+7Pra3kIJZ3Y6p/QF4jq8TqDUBISRpiYiFk?= =?us-ascii?Q?lIneCfSCGuavl4J+KQxtH+tgjT3Y+v6p7QlZQS0ZYVRTXM5vIgrDNrkx6m+N?= =?us-ascii?Q?9kloRWWAtH3U/b4j/nU5eNLJLqdswcrwPUkatXvtm3US5CY6Lb4fj8LOCjH1?= =?us-ascii?Q?tHGgnhU9+2BEJLFPpfZ9nmaPcbGV7s7Yfd6abPqm/844+RMIR5LPjLom2FHU?= =?us-ascii?Q?Oytg7ZB2v/vyO1X2ohXQ4FvpPCgbH62KOjULWCN0wleEZ7Qvz2orLdUx93wF?= =?us-ascii?Q?YLIwkT8iaYq5qNXEZkbiMaTNuLqTfblXe6sgMGjAILNdnZXeDvEokRE+YlvD?= =?us-ascii?Q?9wZYeTu6rM6vSqO8mRFRhRsArcMRsxkU0DG2pQ7NTuv1MOjZzsC3oQX+ViQJ?= =?us-ascii?Q?pZS+P8kd3caO1Ea09Wh7f2fyKY3U69kTNzccGSf8Rfy5Wb/XDuEexCDex+bl?= =?us-ascii?Q?FOIrkftq5FnV9voU5Vn3lwbIkOZznAVlAZCutkkkIb+3oxu4DasTuPsKzRjf?= =?us-ascii?Q?geax8uN8qfTyn5PQ5uRFZke36hOkP+7C6hpSbuLGvY1MmUxY7PqwIiJr6tWt?= =?us-ascii?Q?5wcilhBJYwiamL+LFhdv3ockmls6LOOzR4vbZNLS6r1+6ZSLyO7SnILgyIe0?= =?us-ascii?Q?yrQ1Qx6L30NeaeEm4SuuwbKQxpa8wNHXFUl5k0Zq1c3j+GXrw3TslCfcUH9x?= =?us-ascii?Q?B8LgCZnIdtLRmHtM+6kH5AKExLIQBKKE3wEcI1RiTUzCwQ6fWXo7XLqk/nzi?= =?us-ascii?Q?nwk7d5xKuHfnbQmTQ/oBi2v7Yf6yj?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0501MB1381; 5:narI+FHB9a8Emjzfg/1tBQ+RAPze/CO+DiOUI+fEewo0cQHTc+7wjOwJMmof4oSx5+oyuL1LHkCzZgI55f22zGL8E/JgORKWRgDmMjDTdiXDxEKGUQxn97R0yAQGiadvyfqcw8KxIubMrudQW2a37A==; 24:iAuG9vCHvMI2d/F59imxJKCPHWq1TIJApNRTByqIrC+LtACOskc1pROelzd3nQP+mshzCBVDaQHaWvR9m1dL+kqdUEBiu/gcOi08vvJbcWs= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2015 18:29:20.0107 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0501MB1381 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2015 18:45:03 -0000 Dear Bruce, On 12/30/15, 10:03 PM, "Bruce Evans" wrote: >On Wed, 30 Dec 2015, Jonathan T. Looney wrote: > >> Log: >> Fix a file descriptor leak in mdXhl.c (which is used by numerous >>hashing >> algorithms. > >This code had amazingly low quality and is still especially broken near >the main leak fixed. Thanks for your attention to our code, and for pointing out these bugs. I just volunteered to fix the "new" Coverity alert for a file descriptor leak. (It was a "new" alert due to r292782, which reused this file for SHA384.) However, I agree that there are still bugs in the code, and I'm happy to work on those, too. Happy New Year! Jonathan