From owner-p4-projects@FreeBSD.ORG Sat Jan 17 22:38:14 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 24A221065740; Sat, 17 Jan 2009 22:38:13 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9430C10656C3 for ; Sat, 17 Jan 2009 22:38:12 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8148E8FC1F for ; Sat, 17 Jan 2009 22:38:12 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n0HMcCrI046395 for ; Sat, 17 Jan 2009 22:38:12 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n0HMcCmG046393 for perforce@freebsd.org; Sat, 17 Jan 2009 22:38:12 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Sat, 17 Jan 2009 22:38:12 GMT Message-Id: <200901172238.n0HMcCmG046393@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 156305 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2009 22:38:16 -0000 http://perforce.freebsd.org/chv.cgi?CH=156305 Change 156305 by rwatson@rwatson_freebsd_capabilities on 2009/01/17 22:38:00 When creating a process descriptor for a process, hook it up so that it can be found later. Assert that a process descriptor is closed before freeing it. Affected files ... .. //depot/projects/trustedbsd/capabilities/src/sys/kern/sys_procdesc.c#2 edit Differences ... ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/sys_procdesc.c#2 (text+ko) ==== @@ -208,6 +208,7 @@ pd = uma_zalloc(procdesc_zone, M_WAITOK | M_ZERO); pd->pd_proc = p; pd->pd_pid = p->p_pid; + p->p_procdesc = pd; /* * Process descriptors start out with two references: one from their @@ -226,6 +227,8 @@ if (refcount_release(&pd->pd_refcount)) { KASSERT(pd->pd_proc == NULL, ("procdesc_free: pd_proc != NULL")); + KASSERT((pd->pd_flags & PD_CLOSED), + ("procdesc_free: !PD_CLOSED")); uma_zfree(procdesc_zone, pd); }