From owner-freebsd-hackers  Sun Oct 15 02:57:21 1995
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id CAA19808
          for hackers-outgoing; Sun, 15 Oct 1995 02:57:21 -0700
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id CAA19802
          ; Sun, 15 Oct 1995 02:57:11 -0700
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id TAA13687; Sun, 15 Oct 1995 19:52:54 +1000
Date: Sun, 15 Oct 1995 19:52:54 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199510150952.TAA13687@godzilla.zeta.org.au>
To: freebsd-hackers@freebsd.org, j@uriah.heep.sax.de
Subject: Re: lint
Cc: davidg@freebsd.org, dyson@freebsd.org
Sender: owner-hackers@freebsd.org
Precedence: bulk

>The first thing is what i did.  I've tossed all the header file
>#includes and the external declarations out of those files into a
>single source, and ran it through lint.  I've only been using those
>files that declare external symbols, and in case of the sys/ directory
>only those that declare things for the !KERNEL case.  (List of broken
>sys/ header files: lodef.h, device.h, rlist.h, systm.h, tprintf.h --
>all their function declarations should be #ifdef'ed for KERNEL.)  This
>should ideally yield the interface declarations for libc.

lodef.h seems to be a misspelling.  device.h has never really been used.
Machine-dependent stuff in isa_device.h and stuff in devconf.h is used
instead.  device.h is included in only two places in the kernel:
- in init_main.c where it isn't used
- in si.c where it is used to waste some space in struct si_softc and
  to print the wrong unit number in an error message.
rlist.h is broken.  systm.h is only supposed to be included in the
kernel.  tprintf.h seems pointless.  It only declares a couple of
printf-like functions and is only included once in the kernel.

>Not all of our headers are already self-contained.  I need the
>following list of ``prerequisite headers'':

>#include <sys/types.h>
>#include <sys/param.h>
>#include <sys/time.h>
>#include <netinet/in.h>
>#include <arpa/nameser.h>
>#include <rpc/types.h>
>#include <rpc/xdr.h>

>Failing to declare them on top will cause several headers to fall
>over.

>The rpc/ case is the most iffiest: exactly _this_ sequence is needed,

The 4.4lite2 style guide says to include only one of param.h and
types.h.

I found another unobvious prerequisite: <nfs/rpcv2.h> must be
included before <nfs/nfs.h>.  This is probably a bug in the nfsv3
code.  <nfs/nfs.h> used to be self contained, and lsof expects it
to be self-contained.

Bruce