From nobody Sun Mar 3 08:56:38 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TnbKl11kWz5CLNT; Sun, 3 Mar 2024 08:56:43 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TnbKl0Hj9z4VVN; Sun, 3 Mar 2024 08:56:43 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709456203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/mTr4eztV/C0N7s9JWAqYIjCRVdhbHUihxBhL2jUcBU=; b=DIoeXYrJ4qh0ECHdGrrjKUG9xQoJkNytzYXscR8I85CFoMLdIzA0F/8awud4PFhRt4jiU/ xeAOO0IwWKj+UNvCuG89xmxp3d3MFaPOanhnxCMDpBxlaUADD9ikTx7wjcNaLwdcI796n9 IDsqPQ0zHrs/S4Ze4luR8/DI7T8niN6NUhnStT9pcbCNPWdZ4U835FXmLCBusn4++hf3x2 7y/cLZTVAWZDfv4arH+5lKljyszlHOwnIZKhBD8CKJ+Za/HCuWt4vuxybPrtKpV4JIOhCI NUp6FZ+w7wSalT2To8inPjwmMBV8p2T8tblYmCzRZP0XVy/f3B8CjtFbLzli6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709456203; a=rsa-sha256; cv=none; b=cSknr9w3ZgkohXiSIgOPTwSnXxvywFWf/lteB+MLa+8wIQc543lFR5akAPUeB/4yvoXyc3 XvSpT34pj4joQwxgN+Qmtw8lCEN994YAOsiLJeN6XFrnjql2QRgrONpjjX7hYLN/bE3ntl PYFfp93uR0H3wsCLUfRPn7zFD9Q5i/g1BCYne2sTw6wdU+Ft+6tFaHFXoDE45HkR2XRYPT nS+qSb7dC1aLVfn6bywO/QTJCiRPdr1RP3RtSP9MjY9wHU1drddxcFHG901VPKIJC8okHA jxDocTbZ8+DdKBmAHx/kGNyt9LUTtZZbNl+4gUdXxiIpaKourI9chQsHaD2xcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709456203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/mTr4eztV/C0N7s9JWAqYIjCRVdhbHUihxBhL2jUcBU=; b=fF5kO0M1baeK6sS7cfwpGU+niK17bMaxHf41M9Q+MbpAYjKaOJaX9SRzwp73XJwwY90s2v pDJEjGObJZcwAXdOQKdXA3gb1hucyqzMp5O1fHp1siQign9NZrc/Po9rAafiQm2K8HNcDh niW2fWErauxAgW5+qldWOQnfbDKniQj+Bdiy1pBlGH/goxELKnxS4DfJ3DSpZZSP7gmwJZ BJVTHhA6iPwewpcZPyCZPEwWilkKyejoRYLYqKN79VNg8uTLpIYCf+Lu0utg6hGAz5YV/H /p2oez0B8opwG8/uaQJCdHxKkOZQIuVkOl2xZOPkqBsQjTQH4JaKAqe5WI3b/Q== Received: from relay.mat.cc (eqx1.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TnbKk6GJRz12D5; Sun, 3 Mar 2024 08:56:42 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:fc2e:e297:c004:d357]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id C1EEE20663; Sun, 3 Mar 2024 09:56:39 +0100 (CET) Date: Sun, 3 Mar 2024 09:56:38 +0100 From: Mathieu Arnold To: Gleb Popov Cc: Thomas Zander , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG Message-ID: <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk> References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wvrmk75uij2lfiqu" Content-Disposition: inline In-Reply-To: --wvrmk75uij2lfiqu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 03, 2024 at 09:55:12AM +0300, Gleb Popov wrote: > On Sat, Mar 2, 2024 at 9:36=E2=80=AFPM Thomas Zander = wrote: > > > > The branch main has been updated by riggs: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Da995b8b0ab54b250167531= dafc38fc1342558446 > > > > commit a995b8b0ab54b250167531dafc38fc1342558446 > > Author: Thomas Zander > > AuthorDate: 2024-03-02 10:26:32 +0000 > > Commit: Thomas Zander > > CommitDate: 2024-03-02 18:36:02 +0000 > > > > multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG > > > > Details: > > This is a revert of c1e0f931e3ddecb86d83ffc14cb8b05a38922cdd plus > > removing the DEBUG OPTION from mencoder as well, following the tren= d to > > phase out DEBUG as an option. >=20 > I wouldn't say that there is a trend to remove the DEBUG option, but > this specific change you made does make sense. There is no trend, it's a rule, debug must be handled with WITH_DEBUG knob, and not via an option. If there is an option that enable some sort of debugging or verbose thing but that is not supposed to add debugging symbols, then it should not be called DEBUG. --=20 Mathieu Arnold --wvrmk75uij2lfiqu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXkO0VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb60wwv+POHMjULptpwwzpbynVeKKaNDlikR5eDZ1jNxEFjqPVsJ9L6SM3PMF24g MqL9zqLYggfgi16BQ6CgBw/mj0aJXTwSu412E2V7f1L4nR0Dv6URxwYK/DSGcEWv sNpqHaTYKhL2RBY8TF63G4K7N9heN9242oSoT1J52RsLhv6x1dmGTwjiNgBKwUju HzDhKsvOsFshh+3npytK8NNyFzSoO8d1qB1JdAUOgK4B9c6cwNecchVq+uPmt8Ee PlG12RyOBEWiEV/Id6MFpbsmCvAbYNlTDQ7IYPbyBrP/UvgbsFrToyZBSBjnh+nF R85sXTlUPaezozzl7NYCjh2hxfpeefao1VBigW+AUUl9hkQIdg2adg3OJ1UA0I1h mWD2JSWugzApYJKWllcwjRZrAwah87Klb0u53UfATaVfL/DYJNRmGrQQ5Rw5QxqN nMdDUlPvMf9ne0atIayEAVOh/2vA6AkRhJyY59E5nw6z+XouzTHTAsSJ9k8aF8DR TpM0sqP/ =2vnH -----END PGP SIGNATURE----- --wvrmk75uij2lfiqu--