From owner-svn-src-head@freebsd.org Fri Apr 14 16:20:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D33B1D3DECB; Fri, 14 Apr 2017 16:20:56 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 96C4794F; Fri, 14 Apr 2017 16:20:55 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA09263; Fri, 14 Apr 2017 19:20:48 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1cz3xo-000EYA-3S; Fri, 14 Apr 2017 19:20:48 +0300 Subject: Re: svn commit: r316854 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Alan Somers Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201704141535.v3EFZ7BY096442@repo.freebsd.org> From: Andriy Gapon Message-ID: Date: Fri, 14 Apr 2017 19:19:26 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 16:20:56 -0000 On 14/04/2017 18:55, Alan Somers wrote: > Are you sure it's a good idea to MFC this change? Doing so will upset > anybody currently setting that sysctl in /etc/sysctl.conf. Well, this is a debug knob, so I expected that it is tweaked by hand on as needed basis. I don't expect that it is used as a permanent setting. But to err on the side of caution I can add a compatibility sysctl name. > On Fri, Apr 14, 2017 at 9:35 AM, Andriy Gapon wrote: >> Author: avg >> Date: Fri Apr 14 15:35:07 2017 >> New Revision: 316854 >> URL: https://svnweb.freebsd.org/changeset/base/316854 >> >> Log: >> rename vfs.zfs.debug_flags to vfs.zfs.debugflags >> >> While the former name is easier to read, the "_flags" suffix has a special >> meaning for loader(8) and, thus, it was impossible to set the knob via >> loader.conf(5). The loader interpreted the setting as flags that should >> be passed to a kernel module named "vfs.zfs.debug". >> >> Discussed with: smh >> MFC after: 2 weeks >> >> Modified: >> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c >> >> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c >> ============================================================================== >> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c Fri Apr 14 15:31:04 2017 (r316853) >> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c Fri Apr 14 15:35:07 2017 (r316854) >> @@ -353,7 +353,7 @@ sysctl_vfs_zfs_debug_flags(SYSCTL_HANDLE >> return (0); >> } >> >> -SYSCTL_PROC(_vfs_zfs, OID_AUTO, debug_flags, >> +SYSCTL_PROC(_vfs_zfs, OID_AUTO, debugflags, >> CTLTYPE_UINT | CTLFLAG_MPSAFE | CTLFLAG_RWTUN, 0, sizeof(int), >> sysctl_vfs_zfs_debug_flags, "IU", "Debug flags for ZFS testing."); >> >> -- Andriy Gapon