From owner-svn-src-all@freebsd.org Sun Apr 1 19:35:53 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C989F76C62 for ; Sun, 1 Apr 2018 19:35:53 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 910B67A3D4 for ; Sun, 1 Apr 2018 19:35:52 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: e24ccfc7-35e3-11e8-91c6-33ffc249f3e8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id e24ccfc7-35e3-11e8-91c6-33ffc249f3e8; Sun, 01 Apr 2018 19:35:51 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w31JZjf3076285; Sun, 1 Apr 2018 13:35:45 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1522611345.49673.175.camel@freebsd.org> Subject: Re: svn commit: r327954 - in head/sys: amd64/conf conf dev/acpica vm x86/acpica From: Ian Lepore To: Jeff Roberson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sun, 01 Apr 2018 13:35:45 -0600 In-Reply-To: <201801140336.w0E3a3xv010728@repo.freebsd.org> References: <201801140336.w0E3a3xv010728@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2018 19:35:53 -0000 On Sun, 2018-01-14 at 03:36 +0000, Jeff Roberson wrote: > Author: jeff > Date: Sun Jan 14 03:36:03 2018 > New Revision: 327954 > URL: https://svnweb.freebsd.org/changeset/base/327954 > > Log: >   Move VM_NUMA_ALLOC and DEVICE_NUMA under the single global config > option NUMA. >    >   Sponsored by: Netflix, Dell/EMC Isilon >   Discussed with: jhb It turns out this breaks building powerpc lint kernels. It shakes out like this... makeLINT.mk copies sys/conf/NOTES into the generated LINT config (I guess on the theory that things documented in NOTES are supported by all arches). So option NUMA is present on powerpc, but the powerpc vmparam.h doesn't define VM_LEVEL_0_ORDER so the build fails. (Mips also doesn't define that, but it has no lint kernel build at all right now.) It could be fixed in vm_domainset.c with: -#ifdef NUMA +#if defined(NUMA) && defined(VM_LEVEL_0_ORDER) but there may be some better way to fix it, I don't know that much about this stuff. -- Ian