From owner-freebsd-sparc64@FreeBSD.ORG Mon Oct 31 20:15:19 2011 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7B891065670 for ; Mon, 31 Oct 2011 20:15:19 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate.funkthat.com [70.36.235.232]) by mx1.freebsd.org (Postfix) with ESMTP id B60E88FC15 for ; Mon, 31 Oct 2011 20:15:19 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id p9VJpFwu083809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Oct 2011 12:51:15 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id p9VJpFME083808; Mon, 31 Oct 2011 12:51:15 -0700 (PDT) (envelope-from jmg) Date: Mon, 31 Oct 2011 12:51:14 -0700 From: John-Mark Gurney To: Edward Tomasz Napiera?a Message-ID: <20111031195114.GU25601@funkthat.com> Mail-Followup-To: Edward Tomasz Napiera?a , freebsd-sparc64@freebsd.org References: <52DDA484-9D3D-4305-9692-ADBD7C68BD0B@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52DDA484-9D3D-4305-9692-ADBD7C68BD0B@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Mon, 31 Oct 2011 12:51:15 -0700 (PDT) Cc: freebsd-sparc64@freebsd.org Subject: Re: Fixing bus_dma_tag_create(NULL, ?). X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2011 20:15:19 -0000 Edward Tomasz Napiera?a wrote this message on Mon, Oct 31, 2011 at 14:52 +0100: > On sparc64, calling bus_dma_tag_create(9) with NULL tag will result in instant > panic due to KASSERT. Patch below fixes all the instances I could find. It also fixes > several places unrelated to sparc64, just to give a good example. > > Now, the problem is - the changes are trivial and mechanical, but I have no way > to test most of it, simply because I don't have hardware handled by these drivers. > And I'm not really sure how to proceed from this point. Any ideas? > > Patch can be found at: > > http://people.freebsd.org/~trasz/sparc64-bus_dma_tag_create.diff Maybe posting this patch to -current and -stable would be best. It would give more people the ability to review and test, and be a good reminder to the others that this is the correct usage. I did take a quick look at the patch, and it does look correct. Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."