From owner-svn-src-head@FreeBSD.ORG Thu Mar 12 22:54:24 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EB1272E5; Thu, 12 Mar 2015 22:54:24 +0000 (UTC) Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B478E882; Thu, 12 Mar 2015 22:54:24 +0000 (UTC) Received: by pabrd3 with SMTP id rd3so24186483pab.5; Thu, 12 Mar 2015 15:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=cg4jdGLXktAoSwyrNOBv3ddvPlLESPhL+0sL5ph0GzM=; b=V/lIYLqsRRuRMytGOblwwGCs877Afe/4S3KrLDJsoAR3XuDJLC4W3kQFbR0AfWfMkZ M7kD2HvF9ScUg5m5ID+GZ6WLTQoZkLb4LKlHhuBzp4q7jJ1OPtAsBlp3/44/OrzlSJ3D NmmDqNLhi3yLc2Hi6oMM8731PjIdX8bf9ajfQMFNkXlfBf0PP8j/SOY/QnNHEI3M1Vwd hYziwY2huoHO9VlCRTZKFdXB3yFJQIcTvY2HpUU+pV5E3/vWytNz1dzYo2oe1ktvJzw8 roi4Kc1Ou03GHajp5iy523EOJf8f6slbcmQ8GbjPr7j8+Rgeua6px09gEJ2OlzxFM6NA yiJQ== X-Received: by 10.70.35.193 with SMTP id k1mr83314111pdj.46.1426200864148; Thu, 12 Mar 2015 15:54:24 -0700 (PDT) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.112.58]) by mx.google.com with ESMTPSA id os6sm203428pac.28.2015.03.12.15.54.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2015 15:54:22 -0700 (PDT) Sender: Navdeep Parhar Message-ID: <5502191D.1010901@FreeBSD.org> Date: Thu, 12 Mar 2015 15:54:21 -0700 From: Navdeep Parhar User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r279934 - head/sys/dev/cxgbe References: <201503121822.t2CIML1c044098@svn.freebsd.org> In-Reply-To: <201503121822.t2CIML1c044098@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 22:54:25 -0000 On 03/12/2015 11:22, Ian Lepore wrote: > Author: ian > Date: Thu Mar 12 18:22:20 2015 > New Revision: 279934 > URL: https://svnweb.freebsd.org/changeset/base/279934 > > Log: > Nullterminate strings returned via sysctl. > > PR: 195668 > > Modified: > head/sys/dev/cxgbe/t4_l2t.c > head/sys/dev/cxgbe/t4_main.c > > Modified: head/sys/dev/cxgbe/t4_l2t.c > ============================================================================== > --- head/sys/dev/cxgbe/t4_l2t.c Thu Mar 12 18:09:39 2015 (r279933) > +++ head/sys/dev/cxgbe/t4_l2t.c Thu Mar 12 18:22:20 2015 (r279934) > @@ -321,6 +321,7 @@ skip: > mtx_unlock(&e->lock); > } > > + sbuf_putc(&sb, 0); /* nullterm */ This breaks the build, please fix. Here's the relevant snippet from Jenkins: --- t4_l2t.o --- :324:12: error: incompatible pointer types passing 'struct sbuf **' to parameter of type 'struct sbuf *'; remove & [-Werror,-Wincompatible-pointer-types] sbuf_putc(&sb, 0); /* nullterm */ ^~~ :77:30: note: passing argument to parameter here int sbuf_putc(struct sbuf *, int); ^ 1 error generated. *** [t4_l2t.o] Error code 1